Re: [PATCH 07/15] sequencer: make sequencer_make_script() write its script to a strbuf

2018-10-19 Thread SZEDER Gábor
On Fri, Oct 19, 2018 at 05:16:46PM +0900, Junio C Hamano wrote: > SZEDER Gábor writes: > > >>if (entry) > >> - fprintf(out, "\n%c Branch %s\n", comment_line_char, > >> entry->string); > >> + strbuf_addf(out, "\n%c Branch %s\n", comment_line_char, >

Re: [PATCH 07/15] sequencer: make sequencer_make_script() write its script to a strbuf

2018-10-19 Thread Junio C Hamano
SZEDER Gábor writes: >> if (entry) >> -fprintf(out, "\n%c Branch %s\n", comment_line_char, >> entry->string); >> +strbuf_addf(out, "\n%c Branch %s\n", comment_line_char, >> entry->string); >> else >> -

Re: [PATCH 07/15] sequencer: make sequencer_make_script() write its script to a strbuf

2018-10-12 Thread SZEDER Gábor
On Sun, Oct 07, 2018 at 09:54:10PM +0200, Alban Gruin wrote: > diff --git a/sequencer.c b/sequencer.c > index 30a7fe3958..dfb8d1c974 100644 > --- a/sequencer.c > +++ b/sequencer.c > @@ -4083,7 +4083,7 @@ static const char *label_oid(struct object_id *oid, > const char *label, > } > > static

[PATCH 07/15] sequencer: make sequencer_make_script() write its script to a strbuf

2018-10-07 Thread Alban Gruin
This makes sequencer_make_script() write its script to a strbuf (ie. the buffer of a todo_list) instead of a FILE. This reduce the amount of read/write made by rebase interactive. Signed-off-by: Alban Gruin --- builtin/rebase--interactive.c | 13 +++- sequencer.c | 38