Re: [PATCH 08/24] unpack-trees: remove 'extern' on function declaration

2018-08-15 Thread Stefan Beller
On Wed, Aug 15, 2018 at 12:21 PM Duy Nguyen wrote: > > On Wed, Aug 15, 2018 at 9:10 PM Stefan Beller wrote: > > > > On Mon, Aug 13, 2018 at 9:15 AM Nguyễn Thái Ngọc Duy > > wrote: > > > > > > Signed-off-by: Nguyễn Thái Ngọc Duy > > > > This removes the only existing extern keyword, which was a

Re: [PATCH 08/24] unpack-trees: remove 'extern' on function declaration

2018-08-15 Thread Duy Nguyen
On Wed, Aug 15, 2018 at 9:10 PM Stefan Beller wrote: > > On Mon, Aug 13, 2018 at 9:15 AM Nguyễn Thái Ngọc Duy > wrote: > > > > Signed-off-by: Nguyễn Thái Ngọc Duy > > This removes the only existing extern keyword, which was added by > Linus in 933bf40a5c6 (Start moving unpack-trees to "struct

Re: [PATCH 08/24] unpack-trees: remove 'extern' on function declaration

2018-08-15 Thread Stefan Beller
On Mon, Aug 13, 2018 at 9:15 AM Nguyễn Thái Ngọc Duy wrote: > > Signed-off-by: Nguyễn Thái Ngọc Duy This removes the only existing extern keyword, which was added by Linus in 933bf40a5c6 (Start moving unpack-trees to "struct tree_desc", 2007-08-09). All other callers do not have this noise word

[PATCH 08/24] unpack-trees: remove 'extern' on function declaration

2018-08-13 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- unpack-trees.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/unpack-trees.h b/unpack-trees.h index c2b434c606..534358fcc5 100644 --- a/unpack-trees.h +++ b/unpack-trees.h @@ -82,8 +82,8 @@ struct unpack_trees_options { stru