Re: [PATCH 09/11] refs: move submodule code out of files-backend.c

On Tue, Feb 14, 2017 at 6:35 AM, Stefan Beller wrote: >> + git_dir = read_gitfile(buf.buf); > > if buf.buf is a (git) directory as opposed to a git file, > we error out in read_gitfile. Did you mean to use > read_gitfile_gently here or rather even resolve_gitdir_gently ?

Re: [PATCH 09/11] refs: move submodule code out of files-backend.c

On Mon, Feb 13, 2017 at 7:20 AM, Nguyễn Thái Ngọc Duy wrote: > files-backend is now initialized with a $GIT_DIR. Converting a submodule > path to where real submodule gitdir is located is done in get_ref_store(). > > The new code in init_submodule_ref_store() is basically a

[PATCH 09/11] refs: move submodule code out of files-backend.c

files-backend is now initialized with a $GIT_DIR. Converting a submodule path to where real submodule gitdir is located is done in get_ref_store(). The new code in init_submodule_ref_store() is basically a copy of strbuf_git_path_submodule(). This gives a slight performance improvement for