Re: [PATCH 09/13] Makefile: add c-quote helper function

2014-02-05 Thread Jeff King
On Wed, Feb 05, 2014 at 11:13:24AM -0800, Junio C Hamano wrote: > > +# Quote the value as C string inside a shell string. Good for passing > > strings > > +# on the command line via "-DFOO=$(call # scq,$(FOO))". > > "call # scq"??? Whoops. Bad rewrapping of the comment. It should obviously just

Re: [PATCH 09/13] Makefile: add c-quote helper function

2014-02-05 Thread Junio C Hamano
Jeff King writes: > We have to c-quote strings coming from Makefile variables > when we pass them to the compiler via "-D". Now that we can > use $(call) in our Makefile, we can factor out the quoting > to make things easier to read. We can also apply it more > consistently, as there were many sp

[PATCH 09/13] Makefile: add c-quote helper function

2014-02-05 Thread Jeff King
We have to c-quote strings coming from Makefile variables when we pass them to the compiler via "-D". Now that we can use $(call) in our Makefile, we can factor out the quoting to make things easier to read. We can also apply it more consistently, as there were many spots that should have been C-qu