Re: [PATCH 09/15] http: release the memory of a http pack request as well

2015-03-24 Thread Junio C Hamano
Stefan Beller writes: > Well there is hope, as `release_request` only touches > free(request->url); > free(request); > > and not the userData pointer. OK. > I am a bit puzzled what you're trying to hint at. The caller does this: static void start_fetch_packed(struct transfer_r

Re: [PATCH 09/15] http: release the memory of a http pack request as well

2015-03-24 Thread Stefan Beller
On Sun, Mar 22, 2015 at 12:36 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> The cleanup function is used in 4 places now and it's always safe to >> free up the memory as well. >> >> Signed-off-by: Stefan Beller >> --- >> http.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git

Re: [PATCH 09/15] http: release the memory of a http pack request as well

2015-03-22 Thread Junio C Hamano
Stefan Beller writes: > The cleanup function is used in 4 places now and it's always safe to > free up the memory as well. > > Signed-off-by: Stefan Beller > --- > http.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/http.c b/http.c > index 9c825af..4b179f6 100644 > --- a/http.c > ++

[PATCH 09/15] http: release the memory of a http pack request as well

2015-03-20 Thread Stefan Beller
The cleanup function is used in 4 places now and it's always safe to free up the memory as well. Signed-off-by: Stefan Beller --- http.c | 1 + 1 file changed, 1 insertion(+) diff --git a/http.c b/http.c index 9c825af..4b179f6 100644 --- a/http.c +++ b/http.c @@ -1462,6 +1462,7 @@ void release_