Re: [PATCH 1/1] archive: init archivers before determining format

2018-10-22 Thread Jeff King
On Mon, Oct 22, 2018 at 02:47:56PM -0700, Josh Steadmon wrote: > > Does this work with configured archiver extensions, too? I think so, > > because we load them via init_tar_archiver(). > > If you mean things like .tgz and .tar.gz, then yes, they are affected by > the bug as well, and this patch

Re: [PATCH 1/1] archive: init archivers before determining format

2018-10-22 Thread Josh Steadmon
On 2018.10.19 19:59, Jeff King wrote: > On Fri, Oct 19, 2018 at 04:19:28PM -0700, stead...@google.com wrote: > > > diff --git a/builtin/archive.c b/builtin/archive.c > > index e74f675390..dd3283a247 100644 > > --- a/builtin/archive.c > > +++ b/builtin/archive.c > > @@ -45,7 +45,10 @@ static int

Re: [PATCH 1/1] archive: init archivers before determining format

2018-10-21 Thread Junio C Hamano
Jeff King writes: > On Fri, Oct 19, 2018 at 04:19:28PM -0700, stead...@google.com wrote: > >> diff --git a/builtin/archive.c b/builtin/archive.c >> index e74f675390..dd3283a247 100644 >> --- a/builtin/archive.c >> +++ b/builtin/archive.c >> @@ -45,7 +45,10 @@ static int run_remote_archiver(int

Re: [PATCH 1/1] archive: init archivers before determining format

2018-10-19 Thread Jeff King
On Fri, Oct 19, 2018 at 04:19:28PM -0700, stead...@google.com wrote: > diff --git a/builtin/archive.c b/builtin/archive.c > index e74f675390..dd3283a247 100644 > --- a/builtin/archive.c > +++ b/builtin/archive.c > @@ -45,7 +45,10 @@ static int run_remote_archiver(int argc, const char **argv, >

[PATCH 1/1] archive: init archivers before determining format

2018-10-19 Thread steadmon
When passing both --remote and --output to git-archive, initialize the archivers before attempting to determine the format from the output filename. Without initialization, the format cannot be determined. Signed-off-by: Josh Steadmon --- builtin/archive.c | 5 - 1 file changed, 4