Re: [PATCH 1/1] contrib: add coverage-diff script

2018-09-13 Thread Junio C Hamano
Derrick Stolee writes: > On 9/12/2018 6:54 PM, Junio C Hamano wrote: >> Junio C Hamano writes: >> >>> "Derrick Stolee via GitGitGadget" writes: >>> contrib/coverage-diff.sh | 70 1 file changed, 70 insertions(+) create mode 100755

Re: [PATCH 1/1] contrib: add coverage-diff script

2018-09-13 Thread Derrick Stolee
On 9/12/2018 6:54 PM, Junio C Hamano wrote: Junio C Hamano writes: "Derrick Stolee via GitGitGadget" writes: contrib/coverage-diff.sh | 70 1 file changed, 70 insertions(+) create mode 100755 contrib/coverage-diff.sh I fully appreciate the

Re: [PATCH 1/1] contrib: add coverage-diff script

2018-09-12 Thread Junio C Hamano
Junio C Hamano writes: > "Derrick Stolee via GitGitGadget" writes: > >> contrib/coverage-diff.sh | 70 >> 1 file changed, 70 insertions(+) >> create mode 100755 contrib/coverage-diff.sh > > I fully appreciate the motivation. But it is a bit sad that

Re: [PATCH 1/1] contrib: add coverage-diff script

2018-09-12 Thread Junio C Hamano
"Derrick Stolee via GitGitGadget" writes: > contrib/coverage-diff.sh | 70 > 1 file changed, 70 insertions(+) > create mode 100755 contrib/coverage-diff.sh I fully appreciate the motivation. But it is a bit sad that this begins with "#!/bin/bash" but

[PATCH 1/1] contrib: add coverage-diff script

2018-09-12 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee We have coverage targets in our Makefile for using gcov to display line coverage based on our test suite. The way I like to do it is to run: make coverage-test make coverage-report This leaves the repo in a state where every X.c file that was covered has an