Re: [PATCH 1/1] git-p4: unshelve: use action==add instead of rev==none

>> This was actually discussed in a separate thread [1] some time ago with >> patches proposed by Thandesha and me. >> I haven't yet got time to cook a final patch, which addresses both >> Thandesha's and mine use-cases though, >> so this wasn't submitted to Junio yet. >> In the meantime, I

Re: [PATCH 1/1] git-p4: unshelve: use action==add instead of rev==none

On 23 May 2018 at 17:41, Mazo, Andrey wrote: >> The last one (i.e. "even if it is verbose, if fileSize is not >> reported, do not write the verbose output") does not look like it is >> limited to the unshelve feature, so it might, even though it is a >> one-liner, deserve to

Re: [PATCH 1/1] git-p4: unshelve: use action==add instead of rev==none

> The last one (i.e. "even if it is verbose, if fileSize is not > reported, do not write the verbose output") does not look like it is > limited to the unshelve feature, so it might, even though it is a > one-liner, deserve to be a separate preparatory patch if you want. > But I do not feel

Re: [PATCH 1/1] git-p4: unshelve: use action==add instead of rev==none

Luke Diamand writes: >> However, instead of a separate patch, wouldn't it be better to squash >> it into the previous one? So 'make test' would succeed on every >> commit even with a newer p4 version. > > Junio? > > I can squash together the original commit and the two fixes

Re: [PATCH 1/1] git-p4: unshelve: use action==add instead of rev==none

On 22 May 2018 at 11:15, SZEDER Gábor wrote: > On Tue, May 22, 2018 at 10:41 AM, Luke Diamand wrote: >> SZEDER Gábor found that the unshelve tests fail with newer >> versions of Perforce (2016 vs 2015). >> >> The problem arises because when a file is added

Re: [PATCH 1/1] git-p4: unshelve: use action==add instead of rev==none

On Tue, May 22, 2018 at 10:41 AM, Luke Diamand wrote: > SZEDER Gábor found that the unshelve tests fail with newer > versions of Perforce (2016 vs 2015). > > The problem arises because when a file is added in a P4 > shelved changelist, the depot revision is shown as "none" > if

[PATCH 1/1] git-p4: unshelve: use action==add instead of rev==none

SZEDER Gábor found that the unshelve tests fail with newer versions of Perforce (2016 vs 2015). The problem arises because when a file is added in a P4 shelved changelist, the depot revision is shown as "none" if using the older p4d (which makes sense - the file doesn't yet exist, so can't have a