Re: [PATCH 1/1] mingw: intercept isatty() to handle /dev/null as Git expects it

2016-12-21 Thread Johannes Schindelin
Hi, On Fri, 16 Dec 2016, Junio C Hamano wrote: > Johannes Sixt writes: > > > Am 16.12.2016 um 19:08 schrieb Junio C Hamano: > >> Sorry for not having waited for you to chime in before agreeing to > >> fast-track this one, and now this is in 'master'. > > > > No reason to be

Re: [PATCH 1/1] mingw: intercept isatty() to handle /dev/null as Git expects it

2016-12-16 Thread Junio C Hamano
Johannes Sixt writes: > Am 16.12.2016 um 19:08 schrieb Junio C Hamano: >> Sorry for not having waited for you to chime in before agreeing to >> fast-track this one, and now this is in 'master'. > > No reason to be sorry, things happen... Dscho's request for > fast-tracking was

Re: [PATCH 1/1] mingw: intercept isatty() to handle /dev/null as Git expects it

2016-12-16 Thread Johannes Sixt
Am 16.12.2016 um 19:08 schrieb Junio C Hamano: Sorry for not having waited for you to chime in before agreeing to fast-track this one, and now this is in 'master'. No reason to be sorry, things happen... Dscho's request for fast-tracking was very reasonable, and the patch looked "obviously

Re: [PATCH 1/1] mingw: intercept isatty() to handle /dev/null as Git expects it

2016-12-16 Thread Junio C Hamano
Johannes Sixt writes: > Am 11.12.2016 um 12:16 schrieb Johannes Schindelin: >> When Git's source code calls isatty(), it really asks whether the >> respective file descriptor is connected to an interactive terminal. >> ... >> +if

Re: [PATCH 1/1] mingw: intercept isatty() to handle /dev/null as Git expects it

2016-12-16 Thread Johannes Sixt
Am 11.12.2016 um 12:16 schrieb Johannes Schindelin: When Git's source code calls isatty(), it really asks whether the respective file descriptor is connected to an interactive terminal. Windows' _isatty() function, however, determines whether the file descriptor is associated with a character

[PATCH 1/1] mingw: intercept isatty() to handle /dev/null as Git expects it

2016-12-11 Thread Johannes Schindelin
When Git's source code calls isatty(), it really asks whether the respective file descriptor is connected to an interactive terminal. Windows' _isatty() function, however, determines whether the file descriptor is associated with a character device. And NUL, Windows' equivalent of /dev/null, is a