Re: [PATCH 1/1] mingw: work around t2300's assuming non-Windows paths

2016-06-22 Thread Johannes Schindelin
Hi Junio, On Wed, 22 Jun 2016, Junio C Hamano wrote: > Junio C Hamano writes: > > > I think I know that well enough; please sanity check. My > > understanding is: > > ... > > The patch under discussion is the only door left for that test, and > > a similar trickery is

Re: [PATCH 1/1] mingw: work around t2300's assuming non-Windows paths

2016-06-22 Thread Junio C Hamano
Junio C Hamano writes: > I think I know that well enough; please sanity check. My > understanding is: > ... > The patch under discussion is the only door left for that test, and > a similar trickery is needed for any end-user scripts used for hooks > and aliases that use 'git

Re: [PATCH 1/1] mingw: work around t2300's assuming non-Windows paths

2016-06-22 Thread Johannes Schindelin
Hi Junio, On Wed, 22 Jun 2016, Junio C Hamano wrote: > So let's take that "if Windows do this" change to t2300 as-is. Thanks! Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 1/1] mingw: work around t2300's assuming non-Windows paths

2016-06-22 Thread Junio C Hamano
Johannes Schindelin writes: > On Tue, 21 Jun 2016, Junio C Hamano wrote: > >> I said $PATH because --exec-path does not care what you do with >> %PATH% but it deeply cares that its output is usable in $PATH. > > The really, really, really important part to keep in

Re: [PATCH 1/1] mingw: work around t2300's assuming non-Windows paths

2016-06-22 Thread Johannes Schindelin
Hi Junio, On Tue, 21 Jun 2016, Junio C Hamano wrote: > I said $PATH because --exec-path does not care what you do with > %PATH% but it deeply cares that its output is usable in $PATH. The really, really, really important part to keep in mind is that there is no $PATH on Windows. Seriously,

Re: [PATCH 1/1] mingw: work around t2300's assuming non-Windows paths

2016-06-21 Thread Junio C Hamano
Junio C Hamano writes: > I think you would need something similar to "pwd -W", that is, leave > "git --exec-path" as a way to give shell scripts people have written > over the years that allows them to say "git-cmd" as long as they do > PATH="$(git --exec-path):$PATH" upfront.

Re: [PATCH 1/1] mingw: work around t2300's assuming non-Windows paths

2016-06-21 Thread Junio C Hamano
Johannes Schindelin writes: >> Hmm, I am confused. `git --exec-path` _is_ meant to "spit out" a >> path that is usable when prepended/appended to $PATH [1], and it >> does _not_ have to be POSIX-ish path. It is totally up to the port >> to adjust it to the

Re: [PATCH 1/1] mingw: work around t2300's assuming non-Windows paths

2016-06-21 Thread Johannes Schindelin
Hi Junio, On Mon, 20 Jun 2016, Junio C Hamano wrote: > Johannes Schindelin writes: > > > On Windows, we have to juggle two different schemes of representing > > paths: the native, Windows paths (the only ones known to the main Git > > executable) on the one hand,

Re: [PATCH 1/1] mingw: work around t2300's assuming non-Windows paths

2016-06-20 Thread Junio C Hamano
Johannes Schindelin writes: > On Windows, we have to juggle two different schemes of representing > paths: the native, Windows paths (the only ones known to the main > Git executable) on the one hand, and POSIX-ish ones used by the Bash > through MSYS2's POSIX

[PATCH 1/1] mingw: work around t2300's assuming non-Windows paths

2016-06-18 Thread Johannes Schindelin
On Windows, we have to juggle two different schemes of representing paths: the native, Windows paths (the only ones known to the main Git executable) on the one hand, and POSIX-ish ones used by the Bash through MSYS2's POSIX emulation layer on the other hand. A Windows path looks like this: