Re: [PATCH 1/1] subtree: make install targets depend on build targets

2018-10-18 Thread Christian Hesse
Junio C Hamano on Thu, 2018/10/18 11:09: > Jonathan Nieder writes: > > > The rule says > > > > install-html: html > > $(INSTALL) -d -m 755 $(DESTDIR)$(htmldir) > > $(INSTALL) -m 644 $^ $(DESTDIR)$(htmldir) > > > > and $^ substitutes to "html" after this change. > > Sorry about that.

Re: [PATCH 1/1] subtree: make install targets depend on build targets

2018-10-17 Thread Junio C Hamano
Jonathan Nieder writes: > The rule says > > install-html: html > $(INSTALL) -d -m 755 $(DESTDIR)$(htmldir) > $(INSTALL) -m 644 $^ $(DESTDIR)$(htmldir) > > and $^ substitutes to "html" after this change. Sorry about that. From: Junio C Hamano Date: Thu, 18 Oct 2018 11:07:17 +0900

Re: [PATCH 1/1] subtree: make install targets depend on build targets

2018-10-17 Thread Junio C Hamano
Jonathan Nieder writes: >> -install-html: $(GIT_SUBTREE_HTML) >> +install-html: html > > This broke the build for me: > > make[2]: Entering directory '/build/git-2.19.1+next.20181016/contrib/subtree' > install -m 644 html > /build/git-2.19.1+next.20181016/debian/tmp/usr/share/doc/git/html >

Re: [PATCH 1/1] subtree: make install targets depend on build targets

2018-10-16 Thread Jonathan Nieder
Hi, Christian Hesse wrote: > --- a/contrib/subtree/Makefile > +++ b/contrib/subtree/Makefile > @@ -69,11 +69,11 @@ install: $(GIT_SUBTREE) [...] > -install-html: $(GIT_SUBTREE_HTML) > +install-html: html This broke the build for me: make[2]: Entering directory

Re: [PATCH 1/1] subtree: make install targets depend on build targets

2018-10-16 Thread Junio C Hamano
Christian Hesse writes: > From: Christian Hesse > > Now that we have build targets let the install targets depend on them. > Also make the targets phony. > > Signed-off-by: Christian Hesse > --- > contrib/subtree/Makefile | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Thanks,

[PATCH 1/1] subtree: make install targets depend on build targets

2018-10-16 Thread Christian Hesse
From: Christian Hesse Now that we have build targets let the install targets depend on them. Also make the targets phony. Signed-off-by: Christian Hesse --- contrib/subtree/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/contrib/subtree/Makefile