Re: [PATCH 1/2] Document git config getter return value.

2018-08-01 Thread Eric Sunshine
On Tue, Jul 31, 2018 at 1:37 PM Han-Wen Nienhuys wrote: > diff --git a/config.h b/config.h > @@ -178,10 +178,16 @@ struct config_set { > +/* > + * The int return values in the functions is 1 if not found, 0 if found, > leaving > + * the found value in teh 'dest' pointer. > + */ "teh"? Instead o

[PATCH 1/2] Document git config getter return value.

2018-07-31 Thread Han-Wen Nienhuys
--- config.h | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/config.h b/config.h index b95bb7649..d39256eb1 100644 --- a/config.h +++ b/config.h @@ -178,10 +178,16 @@ struct config_set { }; extern void git_configset_init(struct config_set *cs); -extern int git_co

Re: [PATCH 1/2] Document git config getter return value.

2018-07-30 Thread Junio C Hamano
Eric Sunshine writes: > On Mon, Jul 30, 2018 at 8:26 AM Han-Wen Nienhuys wrote: >> --- >> config.h | 10 -- >> 1 file changed, 8 insertions(+), 2 deletions(-) > > Missing sign-off. Besides, the patch is corrupt in that it miscounts both preimage and postimage lines and claims it applie

Re: [PATCH 1/2] Document git config getter return value.

2018-07-30 Thread Eric Sunshine
On Mon, Jul 30, 2018 at 8:26 AM Han-Wen Nienhuys wrote: > --- > config.h | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) Missing sign-off.

[PATCH 1/2] Document git config getter return value.

2018-07-30 Thread Han-Wen Nienhuys
--- config.h | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/config.h b/config.h index b95bb7649..d39256eb1 100644 --- a/config.h +++ b/config.h @@ -178,11 +178,16 @@ struct config_set { }; extern void git_configset_init(struct config_set *cs); -extern int git_con

[PATCH 1/2] Document git config getter return value.

2018-07-30 Thread Han-Wen Nienhuys
--- config.h | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/config.h b/config.h index b95bb7649..d39256eb1 100644 --- a/config.h +++ b/config.h @@ -178,11 +178,16 @@ struct config_set { }; extern void git_configset_init(struct config_set *cs); -extern int git_con