Re: [PATCH 1/2] Makefile: use find to determine static header dependencies

2014-08-23 Thread Jiang Xin
2014-08-21 22:48 GMT+08:00 Jonathan Nieder jrnie...@gmail.com: Hi, Jeff King wrote: However, we do always define $(LIB_H) as a dependency of po/git.pot. Even though we do not actually try to build that target, make will still evaluate the dependencies when reading the Makefile, and expand

[PATCH 1/2] Makefile: use find to determine static header dependencies

2014-08-21 Thread Jeff King
Most modern platforms will use automatically computed header dependencies to figure out when a C file needs to be rebuilt due to a header changing. With old compilers, however, we fall back to a static list of header files. If any of them changes, we recompile everything. This is overly

Re: [PATCH 1/2] Makefile: use find to determine static header dependencies

2014-08-21 Thread Jonathan Nieder
Hi, Jeff King wrote: However, we do always define $(LIB_H) as a dependency of po/git.pot. Even though we do not actually try to build that target, make will still evaluate the dependencies when reading the Makefile, and expand the variable. This is not ideal Would the following work? The

Re: [PATCH 1/2] Makefile: use find to determine static header dependencies

2014-08-21 Thread Jeff King
On Thu, Aug 21, 2014 at 07:48:18AM -0700, Jonathan Nieder wrote: Subject: i18n: treat make pot as an explicitly-invoked target po/git.pot is normally used as-is and not regenerated by people building git, so it is okay if an explicit make po/git.pot always automatically regenerates it.