Re: [PATCH 1/2] alternates: accept double-quoted paths

2016-12-16 Thread Duy Nguyen
On Wed, Dec 14, 2016 at 1:08 AM, Junio C Hamano wrote: > Duy Nguyen writes: > >> At least attr has the same problem and is going the same direction >> [1]. Cool. (I actually thought the patch was in and evidence that this >> kind of backward compatibility breaking was ok, turns out the patch >> h

Re: [PATCH 1/2] alternates: accept double-quoted paths

2016-12-13 Thread Junio C Hamano
Duy Nguyen writes: > At least attr has the same problem and is going the same direction > [1]. Cool. (I actually thought the patch was in and evidence that this > kind of backward compatibility breaking was ok, turns out the patch > has stayed around for years) > > [1] > http://public-inbox.org/

Re: [PATCH 1/2] alternates: accept double-quoted paths

2016-12-13 Thread Jeff King
On Tue, Dec 13, 2016 at 06:30:15PM +0700, Duy Nguyen wrote: > On Tue, Dec 13, 2016 at 2:52 AM, Jeff King wrote: > > Instead, let's treat names as unquoted unless they begin > > with a double-quote, in which case they are interpreted via > > our usual C-stylke quoting rules. This also breaks > > b

Re: [PATCH 1/2] alternates: accept double-quoted paths

2016-12-13 Thread Duy Nguyen
On Tue, Dec 13, 2016 at 2:52 AM, Jeff King wrote: > Instead, let's treat names as unquoted unless they begin > with a double-quote, in which case they are interpreted via > our usual C-stylke quoting rules. This also breaks > backwards-compatibility, but in a smaller way: it only > matters if your

[PATCH 1/2] alternates: accept double-quoted paths

2016-12-12 Thread Jeff King
We read lists of alternates from objects/info/alternates files (delimited by newline), as well as from the GIT_ALTERNATE_OBJECT_DIRECTORIES environment variable (delimited by colon or semi-colon, depending on the platform). There's no mechanism for quoting the delimiters, so it's impossible to spe