Re: [PATCH 1/2] builtin/blame: dim uninteresting metadata lines

2018-04-17 Thread Junio C Hamano
Stefan Beller writes: > @@ -375,6 +378,7 @@ static void emit_other(struct blame_scoreboard *sb, > struct blame_entry *ent, int > struct commit_info ci; > char hex[GIT_MAX_HEXSZ + 1]; > int show_raw_time = !!(opt & OUTPUT_RAW_TIMESTAMP); > + const char

[PATCH 1/2] builtin/blame: dim uninteresting metadata lines

2018-04-17 Thread Stefan Beller
When using git-blame lots of lines contain redundant information, for example in hunks that consist of multiple lines, the metadata (commit name, author, date) are repeated. A reader may not be interested in those, so offer an option to color the information that is repeated from the previous line

Re: [PATCH 1/2] builtin/blame: dim uninteresting metadata lines

2018-04-17 Thread Stefan Beller
Hi Junio, >> -#define OUTPUT_SHOW_SCORE 0100 >> -#define OUTPUT_NO_AUTHOR 0200 >> +#define OUTPUT_SHOW_SCORE0100 >> +#define OUTPUT_NO_AUTHOR 0200 > > I wondered what these are about; they are about aligning with HT > assuming 8-place tab stop like the other lines. correct.

Re: [PATCH 1/2] builtin/blame: dim uninteresting metadata lines

2018-04-16 Thread Junio C Hamano
Stefan Beller writes: > @@ -316,10 +318,11 @@ static const char *format_time(timestamp_t time, const > char *tz_str, > #define OUTPUT_PORCELAIN 010 > #define OUTPUT_SHOW_NAME 020 > #define OUTPUT_SHOW_NUMBER 040 > -#define OUTPUT_SHOW_SCORE 0100 > -#define

[PATCH 1/2] builtin/blame: dim uninteresting metadata lines

2018-04-16 Thread Stefan Beller
When using git-blame lots of lines contain redundant information, for example in hunks that consist of multiple lines, the metadata (commit name, author, date) are repeated. A reader may not be interested in those, so offer an option to color the information that is repeated from the previous line