Re: [PATCH 1/2] commit: convert lookup_commit_graft to struct object_id

2017-07-13 Thread Junio C Hamano
Stefan Beller writes: > With this patch, commit.h doesn't contain the string 'sha1' any more. ;-) Nice. commit_graft_pos() still thinks we only deal with SHA-1, but that needs to wait for oid_pos(). The function has only two callers that do not pass X->oid.hash so it may

Re: [PATCH 1/2] commit: convert lookup_commit_graft to struct object_id

2017-07-12 Thread brian m. carlson
On Wed, Jul 12, 2017 at 05:44:14PM -0700, Stefan Beller wrote: > With this patch, commit.h doesn't contain the string 'sha1' any more. From a relatively quick look, these look sane to me. -- brian m. carlson / brian with sandals: Houston, Texas, US https://www.crustytoothpaste.net/~bmc | My

[PATCH 1/2] commit: convert lookup_commit_graft to struct object_id

2017-07-12 Thread Stefan Beller
With this patch, commit.h doesn't contain the string 'sha1' any more. Signed-off-by: Stefan Beller --- Before diving into the "RFC object store" series further, I want to get rid of the final sha1s in {commit,tag}.{c,h}. commit.c | 6 +++--- commit.h | 2 +- fsck.c|