Re: [PATCH 1/2] git-fast-import.txt: improve documentation for quoted paths

2012-12-01 Thread Junio C Hamano
Matthieu Moy writes: > Junio C Hamano writes: > >> That "shell-style" contradicts with what fast-import.c says, though. >> It claims to grok \octal and described as C-style. > > As Peff mentionned, my last version is better, although still a bit > incomplete. My new version documents things that

Re: [PATCH 1/2] git-fast-import.txt: improve documentation for quoted paths

2012-11-30 Thread Matthieu Moy
Junio C Hamano writes: > That "shell-style" contradicts with what fast-import.c says, though. > It claims to grok \octal and described as C-style. As Peff mentionned, my last version is better, although still a bit incomplete. My new version documents things that _must_ be escaped, but not what

Re: [PATCH 1/2] git-fast-import.txt: improve documentation for quoted paths

2012-11-29 Thread Jeff King
On Thu, Nov 29, 2012 at 11:15:56AM -0800, Junio C Hamano wrote: > >> -If an `LF` or double quote must be encoded into `` shell-style > >> -quoting should be used, e.g. `"path/with\n and \" in it"`. > >> +If an `LF`, backslash or double quote must be encoded into `` > >> +shell-style quoting should

Re: [PATCH 1/2] git-fast-import.txt: improve documentation for quoted paths

2012-11-29 Thread Junio C Hamano
Jeff King writes: > On Thu, Nov 29, 2012 at 06:00:54PM +0100, Matthieu Moy wrote: > >> The documentation mentionned only newlines and double quotes as > > s/nn/n/ > >> diff --git a/Documentation/git-fast-import.txt >> b/Documentation/git-fast-import.txt >> index 6603a7a..35b909c 100644 >> --- a/

Re: [PATCH 1/2] git-fast-import.txt: improve documentation for quoted paths

2012-11-29 Thread Jeff King
On Thu, Nov 29, 2012 at 07:47:32PM +0100, Matthieu Moy wrote: > Jeff King writes: > > > So technically, your modification to the beginning of the sentence is > > not correct. > > I'd say the resulting sentence is somehow incorrect, but not more than > the previous one (both say "if ..." without

Re: [PATCH 1/2] git-fast-import.txt: improve documentation for quoted paths

2012-11-29 Thread Matthieu Moy
Jeff King writes: > So technically, your modification to the beginning of the sentence is > not correct. I'd say the resulting sentence is somehow incorrect, but not more than the previous one (both say "if ..." without really telling what the condition was). >> If an `LF`, backslash or double

Re: [PATCH 1/2] git-fast-import.txt: improve documentation for quoted paths

2012-11-29 Thread Jeff King
On Thu, Nov 29, 2012 at 06:00:54PM +0100, Matthieu Moy wrote: > The documentation mentionned only newlines and double quotes as s/nn/n/ > diff --git a/Documentation/git-fast-import.txt > b/Documentation/git-fast-import.txt > index 6603a7a..35b909c 100644 > --- a/Documentation/git-fast-import.tx

[PATCH 1/2] git-fast-import.txt: improve documentation for quoted paths

2012-11-29 Thread Matthieu Moy
The documentation mentionned only newlines and double quotes as characters needing escaping, but the backslash also needs it. Also, the documentation was not clearly saying that double quotes around the file name were required (double quotes in the examples could be interpreted as part of the sente