Re: [PATCH 1/2] gitk: simplify file filtering

2012-10-29 Thread Johannes Sixt
Am 10/25/2012 19:23, schrieb Felipe Contreras: git diff is perfectly able to do this with '-- files', no need for manual filtering. It would have been very useful if you summarized what the code did before this change. As for the change itself, it seems to make sense to use git diff's path

[PATCH 1/2] gitk: simplify file filtering

2012-10-25 Thread Felipe Contreras
git diff is perfectly able to do this with '-- files', no need for manual filtering. Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- gitk-git/gitk | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/gitk-git/gitk b/gitk-git/gitk index

[PATCH 1/2] gitk: simplify file filtering

2012-10-19 Thread Felipe Contreras
git diff is perfectly able to do this with '-- files', no need for manual filtering. Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- gitk-git/gitk | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/gitk-git/gitk b/gitk-git/gitk index