Re: [PATCH 1/2] make show-index a builtin

2018-05-28 Thread Jeff King
On Tue, May 29, 2018 at 12:31:53AM +0900, Junio C Hamano wrote: > Jeff King writes: > > > diff --git a/show-index.c b/builtin/show-index.c > > similarity index 96% > > rename from show-index.c > > rename to builtin/show-index.c > > index 1ead41e211..65fa86dd08 100644 > > --- a/show-index.c > >

Re: [PATCH 1/2] make show-index a builtin

2018-05-28 Thread Junio C Hamano
Jeff King writes: > diff --git a/show-index.c b/builtin/show-index.c > similarity index 96% > rename from show-index.c > rename to builtin/show-index.c > index 1ead41e211..65fa86dd08 100644 > --- a/show-index.c > +++ b/builtin/show-index.c > @@ -4,7 +4,7 @@ I squashed #include

[PATCH 1/2] make show-index a builtin

2018-05-28 Thread Jeff King
The git-show-index command is built as its own separate program. There's really no good reason for this, and it means we waste extra space on disk (and CPU time running the linker). Let's fold it in to the main binary as a builtin. The history here is actually a bit amusing. The program itself is