Re: [PATCH 1/2] mingw: verify that paths are not mistaken for remote nicknames

Am 30.05.2017 um 06:46 schrieb Junio C Hamano: Johannes Sixt writes: Doesn't this need test_i18ngrep?: Good catch! It would be this one in warn_on_inaccessible: wrapper.c:581: warning_errno(_("unable to access '%s'"), path); But actually, I'm more worried about the

Re: [PATCH 1/2] mingw: verify that paths are not mistaken for remote nicknames

On 30/05/17 01:03, Junio C Hamano wrote: > Ramsay Jones writes: > >> See commit c7018be509 ("test: allow skipping the remainder", 18-05-2017) >> which is currently merged to the 'next' branch (merge 03b8a61e47 of the >> 'jc/skip-test-in-the-middle' branch). >> >>

Re: [PATCH 1/2] mingw: verify that paths are not mistaken for remote nicknames

Johannes Sixt writes: >> Doesn't this need test_i18ngrep?: > > Good catch! It would be this one in warn_on_inaccessible: > >> wrapper.c:581: warning_errno(_("unable to access '%s'"), path); > > But actually, I'm more worried about the unholy mix of >

Re: [PATCH 1/2] mingw: verify that paths are not mistaken for remote nicknames

Johannes Sixt writes: > I would prefer to catch the case in the compatibility layer. Here is > a two patch series that would replace your 12/13 and 13/13. Thanks. It is good that I can drop that last one. Will replace (with a SQUASH??? for 1/2).

Re: [PATCH 1/2] mingw: verify that paths are not mistaken for remote nicknames

Ramsay Jones writes: > See commit c7018be509 ("test: allow skipping the remainder", 18-05-2017) > which is currently merged to the 'next' branch (merge 03b8a61e47 of the > 'jc/skip-test-in-the-middle' branch). > > (see also http://testanything.org) > > If you look at

Re: [PATCH 1/2] mingw: verify that paths are not mistaken for remote nicknames

Johannes Sixt writes: > Am 29.05.2017 um 22:40 schrieb Ævar Arnfjörð Bjarmason: >> On Mon, May 29, 2017 at 10:25 PM, Johannes Sixt wrote: >>> diff --git a/t/t5580-clone-push-unc.sh b/t/t5580-clone-push-unc.sh >>> index b195f71ea9..fd719a209e 100755 >>> ---

Re: [PATCH 1/2] mingw: verify that paths are not mistaken for remote nicknames

On 29/05/17 22:02, Johannes Sixt wrote: > Am 29.05.2017 um 22:40 schrieb Ævar Arnfjörð Bjarmason: >> On Mon, May 29, 2017 at 10:25 PM, Johannes Sixt wrote: >>> diff --git a/t/t5580-clone-push-unc.sh b/t/t5580-clone-push-unc.sh >>> index b195f71ea9..fd719a209e 100755 >>> ---

Re: [PATCH 1/2] mingw: verify that paths are not mistaken for remote nicknames

Am 29.05.2017 um 22:40 schrieb Ævar Arnfjörð Bjarmason: On Mon, May 29, 2017 at 10:25 PM, Johannes Sixt wrote: diff --git a/t/t5580-clone-push-unc.sh b/t/t5580-clone-push-unc.sh index b195f71ea9..fd719a209e 100755 --- a/t/t5580-clone-push-unc.sh +++ b/t/t5580-clone-push-unc.sh

Re: [PATCH 1/2] mingw: verify that paths are not mistaken for remote nicknames

On Mon, May 29, 2017 at 10:25 PM, Johannes Sixt wrote: > Am 26.05.2017 um 05:35 schrieb Junio C Hamano: >> When asked to open/fopen a path, e.g. "a/b:/c", which does not exist >> on the filesystem, Windows (correctly) fails to open it but sets >> EINVAL to errno because the

[PATCH 1/2] mingw: verify that paths are not mistaken for remote nicknames

Am 26.05.2017 um 05:35 schrieb Junio C Hamano: > When asked to open/fopen a path, e.g. "a/b:/c", which does not exist > on the filesystem, Windows (correctly) fails to open it but sets > EINVAL to errno because the pathname has characters that cannot be > stored in its filesystem. > > As this is