Re: [PATCH 1/2] notes get-ref: --expand expands the output notes ref.

2012-09-10 Thread Johan Herland
On Thu, Sep 6, 2012 at 9:47 PM, Junio C Hamano gits...@pobox.com wrote: W. Trevor King wk...@tremily.us writes: On Wed, Sep 05, 2012 at 10:23:54PM -0700, Junio C Hamano wrote: Really? Would git log --expand master be useful? I'm clearly not an expert on this, but isn't that what git

Re: [PATCH 1/2] notes get-ref: --expand expands the output notes ref.

2012-09-06 Thread W. Trevor King
On Wed, Sep 05, 2012 at 10:23:54PM -0700, Junio C Hamano wrote: Really? Would git log --expand master be useful? I'm clearly not an expert on this, but isn't that what git show-ref master is for? Or is the fact that show-ref returns hashes the more important feature? There was a lot of

Re: [PATCH 1/2] notes get-ref: --expand expands the output notes ref.

2012-09-06 Thread Junio C Hamano
W. Trevor King wk...@tremily.us writes: On Wed, Sep 05, 2012 at 10:23:54PM -0700, Junio C Hamano wrote: Really? Would git log --expand master be useful? I'm clearly not an expert on this, but isn't that what git show-ref master is for? But then can't you say the same against git notes

[PATCH 1/2] notes get-ref: --expand expands the output notes ref.

2012-09-05 Thread W. Trevor King
From: W. Trevor King wk...@tremily.us Useful for debugging refs that don't seem to be expanding correctly. Signed-off-by: W. Trevor King wk...@tremily.us --- Documentation/git-notes.txt | 6 +- builtin/notes.c | 26 +- t/t3301-notes.sh| 8

Re: [PATCH 1/2] notes get-ref: --expand expands the output notes ref.

2012-09-05 Thread Johan Herland
On Wed, Sep 5, 2012 at 2:52 PM, W. Trevor King wk...@tremily.us wrote: From: W. Trevor King wk...@tremily.us Useful for debugging refs that don't seem to be expanding correctly. Signed-off-by: W. Trevor King wk...@tremily.us Acked-by: Johan Herland jo...@herland.net -- Johan Herland,

Re: [PATCH 1/2] notes get-ref: --expand expands the output notes ref.

2012-09-05 Thread Junio C Hamano
Johan Herland jo...@herland.net writes: On Wed, Sep 5, 2012 at 2:52 PM, W. Trevor King wk...@tremily.us wrote: From: W. Trevor King wk...@tremily.us Useful for debugging refs that don't seem to be expanding correctly. Signed-off-by: W. Trevor King wk...@tremily.us Acked-by: Johan Herland