Re: [PATCH 1/2] pack-bitmap: remove bitmap_git global variable

2018-06-11 Thread Jeff King
On Mon, Jun 11, 2018 at 11:50:46AM -0700, Jonathan Tan wrote: > Here's an paragraph to be added to the end of the commit message. I can > send a reroll with the exact same code but with the updated commit > message if Junio requests it. > > [additional paragraph begin] > > This patch raises two

Re: [PATCH 1/2] pack-bitmap: remove bitmap_git global variable

2018-06-11 Thread Jonathan Tan
On Sat, 9 Jun 2018 02:04:38 -0400 Jeff King wrote: > This function used to be idempotent, so any code which wanted to use the > global bitmap_git could call it "just in case". After your patch, it's > not. I think it's probably OK, since such functions would generally now > take a bitmap_git

Re: [PATCH 1/2] pack-bitmap: remove bitmap_git global variable

2018-06-09 Thread Jeff King
On Thu, Jun 07, 2018 at 12:04:13PM -0700, Jonathan Tan wrote: > Remove the bitmap_git global variable. Instead, generate on demand an > instance of struct bitmap_index for code that needs to access it. > > This allows us significant control over the lifetime of instances of > struct

[PATCH 1/2] pack-bitmap: remove bitmap_git global variable

2018-06-07 Thread Jonathan Tan
Remove the bitmap_git global variable. Instead, generate on demand an instance of struct bitmap_index for code that needs to access it. This allows us significant control over the lifetime of instances of struct bitmap_index. In particular, packs can now be closed without worrying if an