Re: [PATCH 1/2] rebase: support --signoff with implicit rebase

2018-03-16 Thread Johannes Schindelin
Hi Phillip, On Thu, 15 Mar 2018, Phillip Wood wrote: > On 15/03/18 10:18, Johannes Schindelin wrote: > > > As I mentioned in my reply to Junio's comment, it'd be awesome if > > --interactive --signoff was supported (and likewise --merge > > --signoff), but it feels like an undue feature request

Re: [PATCH 1/2] rebase: support --signoff with implicit rebase

2018-03-15 Thread Phillip Wood
On 15/03/18 10:18, Johannes Schindelin wrote: > Hi Phillip, > > On Wed, 14 Mar 2018, Phillip Wood wrote: > >> diff --git a/git-rebase.sh b/git-rebase.sh >> index b353c33d41..40301756be 100755 >> --- a/git-rebase.sh >> +++ b/git-rebase.sh >> @@ -459,6 +471,18 @@ then >>

Re: [PATCH 1/2] rebase: support --signoff with implicit rebase

2018-03-15 Thread Johannes Schindelin
Hi Phillip, On Wed, 14 Mar 2018, Phillip Wood wrote: > diff --git a/git-rebase.sh b/git-rebase.sh > index b353c33d41..40301756be 100755 > --- a/git-rebase.sh > +++ b/git-rebase.sh > @@ -459,6 +471,18 @@ then > git_format_patch_opt="$git_format_patch_opt --progress" > fi > > +if test -n

Re: [PATCH 1/2] rebase: support --signoff with implicit rebase

2018-03-15 Thread Johannes Schindelin
Hi Junio, On Wed, 14 Mar 2018, Junio C Hamano wrote: > Phillip Wood writes: > > > From: Phillip Wood > > > > This allows one to run 'git rebase --exec "make check" --signoff' > > which is useful when preparing a patch series for

Re: [PATCH 1/2] rebase: support --signoff with implicit rebase

2018-03-14 Thread Junio C Hamano
Phillip Wood writes: > From: Phillip Wood > > This allows one to run 'git rebase --exec "make check" --signoff' > which is useful when preparing a patch series for publication and is > more convenient than doing the signoff with another

[PATCH 1/2] rebase: support --signoff with implicit rebase

2018-03-14 Thread Phillip Wood
From: Phillip Wood This allows one to run 'git rebase --exec "make check" --signoff' which is useful when preparing a patch series for publication and is more convenient than doing the signoff with another --exec command. This change also allows --root without --onto