Re: [PATCH 1/2] rebase -i: demonstrate incorrect behavior of post-rewrite hook with exec

2015-05-22 Thread Matthieu Moy
Eric Sunshine sunsh...@sunshineco.com writes: +test_expect_failure 'git rebase -i (exec)' ' + git reset --hard D + clear_hook_input + FAKE_LINES=edit 1 exec_false 2 git rebase -i B Broken -chain. Thanks, will add in v2. -- Matthieu Moy http://www-verimag.imag.fr/~moy/

[PATCH 1/2] rebase -i: demonstrate incorrect behavior of post-rewrite hook with exec

2015-05-21 Thread Matthieu Moy
The 'exec' command is sending the current commit to stopped-sha, which is supposed to contain the original commit (before rebase). As a result, if an 'exec' command fails, the next 'git rebase --continue' will send the current commit as old-sha1 to the post-rewrite hook. The test currently fails

Re: [PATCH 1/2] rebase -i: demonstrate incorrect behavior of post-rewrite hook with exec

2015-05-21 Thread Eric Sunshine
On Thu, May 21, 2015 at 2:13 PM, Matthieu Moy matthieu@imag.fr wrote: The 'exec' command is sending the current commit to stopped-sha, which is supposed to contain the original commit (before rebase). As a result, if an 'exec' command fails, the next 'git rebase --continue' will send the