Re: [PATCH 1/2] t3507: add a testcase showing failure with sparse checkout

2018-07-23 Thread Ben Peart
On 7/23/2018 2:09 PM, Eric Sunshine wrote: On Mon, Jul 23, 2018 at 9:12 AM Ben Peart wrote: On 7/21/2018 3:21 AM, Eric Sunshine wrote: On Sat, Jul 21, 2018 at 2:34 AM Elijah Newren wrote: + rm .git/info/sparse-checkout Should this cleanup be done by test_when_finished()? I think

Re: [PATCH 1/2] t3507: add a testcase showing failure with sparse checkout

2018-07-23 Thread Junio C Hamano
Ben Peart writes: > On 7/21/2018 2:34 AM, Elijah Newren wrote: >> From: Ben Peart >> >> Signed-off-by: Elijah Newren >> --- >> Testcase provided by Ben, so committing with him as the author. Just need >> a sign off from him. > > Thanks Elijah, consider it > > Signed-off-by: Ben Peart > Thank

Re: [PATCH 1/2] t3507: add a testcase showing failure with sparse checkout

2018-07-23 Thread Eric Sunshine
On Mon, Jul 23, 2018 at 9:12 AM Ben Peart wrote: > On 7/21/2018 3:21 AM, Eric Sunshine wrote: > > On Sat, Jul 21, 2018 at 2:34 AM Elijah Newren wrote: > >> + rm .git/info/sparse-checkout > > > > Should this cleanup be done by test_when_finished()? > > I think trying to use test_when_finishe

Re: [PATCH 1/2] t3507: add a testcase showing failure with sparse checkout

2018-07-23 Thread Ben Peart
On 7/21/2018 3:21 AM, Eric Sunshine wrote: On Sat, Jul 21, 2018 at 2:34 AM Elijah Newren wrote: diff --git a/t/t3507-cherry-pick-conflict.sh b/t/t3507-cherry-pick-conflict.sh @@ -392,4 +392,17 @@ test_expect_success 'commit --amend -s places the sign-off at the right place' ' +test_expect_f

Re: [PATCH 1/2] t3507: add a testcase showing failure with sparse checkout

2018-07-21 Thread Ben Peart
On 7/21/2018 2:34 AM, Elijah Newren wrote: From: Ben Peart Signed-off-by: Elijah Newren --- Testcase provided by Ben, so committing with him as the author. Just need a sign off from him. Thanks Elijah, consider it Signed-off-by: Ben Peart t/t3507-cherry-pick-conflict.sh | 13

Re: [PATCH 1/2] t3507: add a testcase showing failure with sparse checkout

2018-07-21 Thread Eric Sunshine
On Sat, Jul 21, 2018 at 2:34 AM Elijah Newren wrote: > diff --git a/t/t3507-cherry-pick-conflict.sh b/t/t3507-cherry-pick-conflict.sh > @@ -392,4 +392,17 @@ test_expect_success 'commit --amend -s places the > sign-off at the right place' ' > +test_expect_failure 'failed cherry-pick with sparse-ch

[PATCH 1/2] t3507: add a testcase showing failure with sparse checkout

2018-07-20 Thread Elijah Newren
From: Ben Peart Signed-off-by: Elijah Newren --- Testcase provided by Ben, so committing with him as the author. Just need a sign off from him. t/t3507-cherry-pick-conflict.sh | 13 + 1 file changed, 13 insertions(+) diff --git a/t/t3507-cherry-pick-conflict.sh b/t/t3507-cherry-p