Re: [PATCH 1/2] upload-pack: avoid parsing objects during ref advertisement

2013-01-29 Thread Shawn Pearce
On Fri, Jan 6, 2012 at 11:17 AM, Jeff King p...@peff.net wrote: When we advertise a ref, the first thing we do is parse the pointed-to object. This gives us two things: ... The downside is that we are no longer verifying objects that we advertise by fully parsing them (however, we do still

Re: [PATCH 1/2] upload-pack: avoid parsing objects during ref advertisement

2013-01-24 Thread Junio C Hamano
Jeff King p...@peff.net writes: And yeah, this should use lookup_unknown_object to extend the optimization to mark_our_ref (and avoid removing it for the ref-advertisement case, of course). Thanks for sanity checking. Here is what is queued at the bottom of the hide-refs topic. -- 8 --

Re: [PATCH 1/2] upload-pack: avoid parsing objects during ref advertisement

2013-01-18 Thread Junio C Hamano
Jeff King p...@peff.net writes: When we advertise a ref, the first thing we do is parse the pointed-to object. This gives us two things: 1. a struct object we can use to store flags 2. the type of the object, so we know whether we need to dereference it as a tag Instead, we can