Re: [PATCH 1/2] upload-pack: avoid parsing objects during ref advertisement

2013-01-18 Thread Junio C Hamano
Jeff King writes: > When we advertise a ref, the first thing we do is parse the > pointed-to object. This gives us two things: > > 1. a "struct object" we can use to store flags > > 2. the type of the object, so we know whether we need to > dereference it as a tag > > Instead, we can jus

Re: [PATCH 1/2] upload-pack: avoid parsing objects during ref advertisement

2013-01-23 Thread Jeff King
On Fri, Jan 18, 2013 at 03:12:52PM -0800, Junio C Hamano wrote: > Jeff King writes: > > > When we advertise a ref, the first thing we do is parse the > > pointed-to object. This gives us two things: > > > > 1. a "struct object" we can use to store flags > > > > 2. the type of the object, so

Re: [PATCH 1/2] upload-pack: avoid parsing objects during ref advertisement

2013-01-24 Thread Junio C Hamano
Jeff King writes: > And yeah, this should use lookup_unknown_object to extend the > optimization to mark_our_ref (and avoid removing it for the > ref-advertisement case, of course). Thanks for sanity checking. Here is what is queued at the bottom of the hide-refs topic. -- >8 -- Date: Fri, 18

Re: [PATCH 1/2] upload-pack: avoid parsing objects during ref advertisement

2013-01-29 Thread Shawn Pearce
On Fri, Jan 6, 2012 at 11:17 AM, Jeff King wrote: > When we advertise a ref, the first thing we do is parse the > pointed-to object. This gives us two things: ... > The downside is that we are no longer verifying objects that > we advertise by fully parsing them (however, we do still > know we act

Re: [PATCH 1/2] upload-pack: avoid parsing objects during ref advertisement

2013-01-29 Thread Jeff King
On Tue, Jan 29, 2013 at 12:10:59AM -0800, Shawn O. Pearce wrote: > > On a repository with 120K refs, the advertisement portion of > > upload-pack goes from ~3.4s to 3.2s (the failure to speed up > > more is largely due to the fact that most of these refs are > > tags, which need dereferenced to fi