Re: [PATCH 1/3][GSOC] diff: rename read_directory() to get_directory_list()

2014-03-19 Thread Eric Sunshine
On Mon, Mar 17, 2014 at 5:30 PM, Hiroyuki Sano sh19910...@gmail.com wrote: Including dir.h in diff-no-index.c, it causes a compile error, because the same name function read_directory() is declared globally in dir.h. This change is to avoid conflicts as above. This explanation is slightly

Re: [PATCH 1/3][GSOC] diff: rename read_directory() to get_directory_list()

2014-03-19 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: Hiroyuki Sano sh19910...@gmail.com writes: Including dir.h in diff-no-index.c, it causes a compile error, because the same name function read_directory() is declared globally in dir.h. This change is to avoid conflicts as above. Signed-off-by:

Re: [PATCH 1/3][GSOC] diff: rename read_directory() to get_directory_list()

2014-03-19 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: -static int read_directory(const char *path, struct string_list *list) +static int get_directory_list(const char *path, struct string_list *list) Renaming is a good idea but the new name sounds like you are grabbing the names of directories, ignoring

[PATCH 1/3][GSOC] diff: rename read_directory() to get_directory_list()

2014-03-17 Thread Hiroyuki Sano
Including dir.h in diff-no-index.c, it causes a compile error, because the same name function read_directory() is declared globally in dir.h. This change is to avoid conflicts as above. Signed-off-by: Hiroyuki Sano sh19910...@gmail.com --- diff-no-index.c | 6 +++--- 1 file changed, 3

Re: [PATCH 1/3][GSOC] diff: rename read_directory() to get_directory_list()

2014-03-17 Thread Junio C Hamano
Hiroyuki Sano sh19910...@gmail.com writes: Including dir.h in diff-no-index.c, it causes a compile error, because the same name function read_directory() is declared globally in dir.h. This change is to avoid conflicts as above. Signed-off-by: Hiroyuki Sano sh19910...@gmail.com ---