Re: [PATCH 1/3] [Outreachy] t3903-stash: test without configured user name

2018-10-24 Thread Junio C Hamano
Slavica writes: > On 23-Oct-18 8:52 PM, Christian Couder wrote: >> On Tue, Oct 23, 2018 at 6:35 PM Slavica wrote: >>> This is part of enhancement request that ask for `git stash` to work even >>> if `user.name` is not configured. >>> The issue is discussed here: >>>

Re: [PATCH 1/3] [Outreachy] t3903-stash: test without configured user name

2018-10-24 Thread Junio C Hamano
Johannes Schindelin writes: >> HOME is set to TRASH_DIRECTORY in t/test-lib.sh already, and we do >> so to avoid getting affected by the real $HOME/.gitconfig of the >> user who happens to be running the test suite. > > My bad. I should have checked. I was under the impression that we set >

Re: [PATCH 1/3] [Outreachy] t3903-stash: test without configured user name

2018-10-24 Thread Johannes Schindelin
Hi Junio, On Wed, 24 Oct 2018, Junio C Hamano wrote: > Johannes Schindelin writes: > > > On Wed, 24 Oct 2018, Junio C Hamano wrote: > > > >> Slavica writes: > >> > >> > +test_expect_failure 'stash with HOME as non-existing directory' ' > >> > +test_commit 1 && > >> > +test_config

Re: [PATCH 1/3] [Outreachy] t3903-stash: test without configured user name

2018-10-24 Thread Slavica
On 23-Oct-18 8:52 PM, Christian Couder wrote: On Tue, Oct 23, 2018 at 6:35 PM Slavica wrote: This is part of enhancement request that ask for `git stash` to work even if `user.name` is not configured. The issue is discussed here:

Re: [PATCH 1/3] [Outreachy] t3903-stash: test without configured user name

2018-10-24 Thread Junio C Hamano
Johannes Schindelin writes: > Hi Junio, > > On Wed, 24 Oct 2018, Junio C Hamano wrote: > >> Slavica writes: >> >> > +test_expect_failure 'stash with HOME as non-existing directory' ' >> > +test_commit 1 && >> > +test_config user.useconfigonly true && >> > +test_config

Re: [PATCH 1/3] [Outreachy] t3903-stash: test without configured user name

2018-10-24 Thread Johannes Schindelin
Hi Junio, On Wed, 24 Oct 2018, Junio C Hamano wrote: > Slavica writes: > > > +test_expect_failure 'stash with HOME as non-existing directory' ' > > +test_commit 1 && > > +test_config user.useconfigonly true && > > +test_config stash.usebuiltin true && > > +( > > +

Re: [PATCH 1/3] [Outreachy] t3903-stash: test without configured user name

2018-10-23 Thread Junio C Hamano
Slavica writes: > +test_expect_failure 'stash with HOME as non-existing directory' ' > +test_commit 1 && > +test_config user.useconfigonly true && > +test_config stash.usebuiltin true && > +( > +HOME=$(pwd)/none && > +export HOME && What is the reason why this

Re: [PATCH 1/3] [Outreachy] t3903-stash: test without configured user name

2018-10-23 Thread Eric Sunshine
On Tue, Oct 23, 2018 at 12:31 PM Slavica wrote: > This is part of enhancement request that ask for `git stash` to work even if > `user.name` is not configured. > The issue is discussed here: > https://public-inbox.org/git/87o9debty4@evledraar.gmail.com/T/#u. As Christian mentioned already,

Re: [PATCH 1/3] [Outreachy] t3903-stash: test without configured user name

2018-10-23 Thread Christian Couder
On Tue, Oct 23, 2018 at 6:35 PM Slavica wrote: > > This is part of enhancement request that ask for `git stash` to work even if > `user.name` is not configured. > The issue is discussed here: > https://public-inbox.org/git/87o9debty4@evledraar.gmail.com/T/#u. We prefer commit messages that

[PATCH 1/3] [Outreachy] t3903-stash: test without configured user name

2018-10-23 Thread Slavica
This is part of enhancement request that ask for `git stash` to work even if `user.name` is not configured. The issue is discussed here: https://public-inbox.org/git/87o9debty4@evledraar.gmail.com/T/#u. Signed-off-by: Slavica --- t/t3903-stash.sh | 17 + 1 file changed, 17