Re: [PATCH 1/3] add git_psprintf helper function

2017-02-16 Thread Jeff King
On Thu, Feb 16, 2017 at 07:51:14AM -0800, Jonathan Tan wrote: > On 02/16/2017 03:28 AM, Maxim Moseychuk wrote: > > There are a number of places in the code where we call > > xsnprintf(), with the assumption that the output will fit into > > the buffer. If the buffer is small, then git die. > > In

Re: [PATCH 1/3] add git_psprintf helper function

2017-02-16 Thread Jonathan Tan
On 02/16/2017 03:28 AM, Maxim Moseychuk wrote: There are a number of places in the code where we call xsnprintf(), with the assumption that the output will fit into the buffer. If the buffer is small, then git die. In many places buffers have compile-time size, but generated string depends from c

[PATCH 1/3] add git_psprintf helper function

2017-02-16 Thread Maxim Moseychuk
There are a number of places in the code where we call xsnprintf(), with the assumption that the output will fit into the buffer. If the buffer is small, then git die. In many places buffers have compile-time size, but generated string depends from current system locale (gettext)and can have size g