Re: [PATCH 1/3] archive: use packet_reader for communications

2018-09-13 Thread Junio C Hamano
Junio C Hamano writes: >> -if (packet_read_line(fd[0], NULL)) >> +status = packet_reader_read(); >> +if (status != PACKET_READ_FLUSH) >> die(_("git archive: expected a flush")); > > This makes me wonder what happens if we got an EOF instead. We fail > to notice protocol

Re: [PATCH 1/3] archive: use packet_reader for communications

2018-09-13 Thread Junio C Hamano
Josh Steadmon writes: > Using packet_reader will simplify version detection and capability > handling, which will make implementation of protocol v2 support in > git-archive easier. Is this meant as a change in implementation without any change in behaviour? > Signed-off-by: Josh Steadmon >

Re: [PATCH 1/3] archive: use packet_reader for communications

2018-09-12 Thread Stefan Beller
On Tue, Sep 11, 2018 at 10:35 PM Josh Steadmon wrote: > > Using packet_reader will simplify version detection and capability > handling, which will make implementation of protocol v2 support in > git-archive easier. > > Signed-off-by: Josh Steadmon Reviewed-by: Stefan Beller

[PATCH 1/3] archive: use packet_reader for communications

2018-09-11 Thread Josh Steadmon
Using packet_reader will simplify version detection and capability handling, which will make implementation of protocol v2 support in git-archive easier. Signed-off-by: Josh Steadmon --- builtin/archive.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git