Re: [PATCH 1/3] configure.ac: check 'tv_nsec' field in 'struct stat'

On Thu, Jan 8, 2015 at 3:00 PM, Reuben Hawkins wrote: > Detect 'tv_nsec' field in 'struct stat' and set Makefile variable > NO_NSEC appropriately. > > A side-effect of the above detection is that we also determine > whether 'stat.st_mtimespec' is available, so, as a bonus, set the > Makefile varia

[PATCH 1/3] configure.ac: check 'tv_nsec' field in 'struct stat'

Detect 'tv_nsec' field in 'struct stat' and set Makefile variable NO_NSEC appropriately. A side-effect of the above detection is that we also determine whether 'stat.st_mtimespec' is available, so, as a bonus, set the Makefile variable USE_ST_TIMESPEC, as well. Signed-off-by: Reuben Hawkins ---

Re: [PATCH 1/3] configure.ac: check tv_nsec field in struct stat

On Wed, Jan 7, 2015 at 5:19 PM, Reuben Hawkins wrote: > On Wed, Jan 7, 2015 at 1:19 PM, Eric Sunshine wrote: >> On Wed, Jan 7, 2015 at 3:23 PM, Reuben Hawkins wrote: >>> This check will automatically set the correct NO_NSEC setting. >> >> This commit message neglects to mention the important poi

Re: [PATCH 1/3] configure.ac: check tv_nsec field in struct stat

On Wed, Jan 7, 2015 at 1:19 PM, Eric Sunshine wrote: > On Wed, Jan 7, 2015 at 3:23 PM, Reuben Hawkins wrote: >> This check will automatically set the correct NO_NSEC setting. > > This commit message neglects to mention the important point that > you're also now setting USE_ST_TIMESPEC when detect

Re: [PATCH 1/3] configure.ac: check tv_nsec field in struct stat

On Wed, Jan 7, 2015 at 4:33 PM, Reuben Hawkins wrote: > On Wed, Jan 7, 2015 at 1:19 PM, Eric Sunshine wrote: >> On Wed, Jan 7, 2015 at 3:23 PM, Reuben Hawkins wrote: >>> +# Define USE_ST_TIMESPEC=YesPlease when stat.st_mtimespec.tv_nsec exist >> >> It would be slightly more accurate to drop the

Re: [PATCH 1/3] configure.ac: check tv_nsec field in struct stat

On Wed, Jan 7, 2015 at 1:19 PM, Eric Sunshine wrote: > On Wed, Jan 7, 2015 at 3:23 PM, Reuben Hawkins wrote: >> This check will automatically set the correct NO_NSEC setting. > > This commit message neglects to mention the important point that > you're also now setting USE_ST_TIMESPEC when detect

Re: [PATCH 1/3] configure.ac: check tv_nsec field in struct stat

On Wed, Jan 7, 2015 at 3:23 PM, Reuben Hawkins wrote: > This check will automatically set the correct NO_NSEC setting. This commit message neglects to mention the important point that you're also now setting USE_ST_TIMESPEC when detected. You might revise the message like this: Detect 'tv_ns

[PATCH 1/3] configure.ac: check tv_nsec field in struct stat

This check will automatically set the correct NO_NSEC setting. --- configure.ac | 12 1 file changed, 12 insertions(+) diff --git a/configure.ac b/configure.ac index 6af9647..dcc4bf0 100644 --- a/configure.ac +++ b/configure.ac @@ -754,6 +754,18 @@ AC_CHECK_TYPES([struct itimerval],

Re: [PATCH 1/3] configure.ac: check tv_nsec field in struct stat

On Sun, Dec 21, 2014 at 3:20 PM, Eric Sunshine wrote: > On Sun, Dec 21, 2014 at 1:53 PM, Reuben Hawkins wrote: >> +AC_CHECK_MEMBER([struct stat.st_mtim.tv_nsec], >> +[HAVE_ST_MTIM=Yes], >> +[HAVE_ST_MTIM=No], > > In Autoconf, it's customary to use lowercase values (such as "yes" > rather than "Ye

Re: [PATCH 1/3] configure.ac: check tv_nsec field in struct stat

On Sun, Dec 21, 2014 at 1:53 PM, Reuben Hawkins wrote: > This check will automatically set the correct NO_NSEC setting. Missing sign-off. See git/Documentation/SubmittingPatches. > --- > diff --git a/configure.ac b/configure.ac > index 6af9647..3cfdd51 100644 > --- a/configure.ac > +++ b/configu

[PATCH 1/3] configure.ac: check tv_nsec field in struct stat

This check will automatically set the correct NO_NSEC setting. --- configure.ac | 19 +++ 1 file changed, 19 insertions(+) diff --git a/configure.ac b/configure.ac index 6af9647..3cfdd51 100644 --- a/configure.ac +++ b/configure.ac @@ -754,6 +754,25 @@ AC_CHECK_TYPES([struct itime