Re: [PATCH 1/3] fast-export: add --signed-tags=warn-strip mode

2013-04-16 Thread John Keeping
On Mon, Apr 15, 2013 at 09:50:42PM -0700, Sverre Rabbelier wrote: On Mon, Apr 15, 2013 at 9:47 PM, Junio C Hamano gits...@pobox.com wrote: When you see 78 in the output and you know you have 92 tags in the repository, is that sufficient to let you go on, or do we also need an easy way to

Re: [PATCH 1/3] fast-export: add --signed-tags=warn-strip mode

2013-04-16 Thread Junio C Hamano
John Keeping j...@keeping.me.uk writes: Printing one message per tag also matches the current behaviour for --signed-tags=warn. I don't want to make the behaviour for warn and warn-strip different,... That is a valid point. Nobody has complained that the current warning is too noisy, so

Re: [PATCH 1/3] fast-export: add --signed-tags=warn-strip mode

2013-04-16 Thread Sverre Rabbelier
On Tue, Apr 16, 2013 at 9:48 PM, Junio C Hamano gits...@pobox.com wrote: That is a valid point. Nobody has complained that the current warning is too noisy, so perhaps the patch is good as-is? Ah, hadn't realized that. Probably fine then. -- Cheers, Sverre Rabbelier -- To unsubscribe from

Re: [PATCH 1/3] fast-export: add --signed-tags=warn-strip mode

2013-04-15 Thread Sverre Rabbelier
On Sun, Apr 14, 2013 at 3:57 AM, John Keeping j...@keeping.me.uk wrote: This issues a warning while stripping signatures from signed tags, which allows us to use it as default behaviour for remote helpers which cannot specify how to handle signed tags. Perhaps it makes sense to instead count

Re: [PATCH 1/3] fast-export: add --signed-tags=warn-strip mode

2013-04-15 Thread Junio C Hamano
Sverre Rabbelier srabbel...@gmail.com writes: On Sun, Apr 14, 2013 at 3:57 AM, John Keeping j...@keeping.me.uk wrote: This issues a warning while stripping signatures from signed tags, which allows us to use it as default behaviour for remote helpers which cannot specify how to handle signed

Re: [PATCH 1/3] fast-export: add --signed-tags=warn-strip mode

2013-04-15 Thread Sverre Rabbelier
On Mon, Apr 15, 2013 at 9:47 PM, Junio C Hamano gits...@pobox.com wrote: When you see 78 in the output and you know you have 92 tags in the repository, is that sufficient to let you go on, or do we also need an easy way to tell which ones are those 78 that were stripped and the remaining 14

Re: [PATCH 1/3] fast-export: add --signed-tags=warn-strip mode

2013-04-15 Thread Jonathan Nieder
Junio C Hamano wrote: Sverre Rabbelier srabbel...@gmail.com writes: Perhaps it makes sense to instead count the number of signed tags and emit Stripped signature from %d tags? For example, for git.git it would be on the order of a hundred warning lines. When you see 78 in the output and you

[PATCH 1/3] fast-export: add --signed-tags=warn-strip mode

2013-04-14 Thread John Keeping
This issues a warning while stripping signatures from signed tags, which allows us to use it as default behaviour for remote helpers which cannot specify how to handle signed tags. Signed-off-by: John Keeping j...@keeping.me.uk --- Documentation/git-fast-export.txt | 10 ++