[PATCH 1/3] fix clang -Wtautological-compare with unsigned enum

2013-02-03 Thread John Keeping
From: Antoine Pelisse apeli...@gmail.com Create a GREP_HEADER_FIELD_MIN so we can check that the field value is sane and silent the clang warning. Clang warning happens because the enum is unsigned (this is implementation-defined, and there is no negative fields) and the check is then

Re: [PATCH 1/3] fix clang -Wtautological-compare with unsigned enum

2013-02-03 Thread Jonathan Nieder
John Keeping wrote: From: Antoine Pelisse apeli...@gmail.com Create a GREP_HEADER_FIELD_MIN so we can check that the field value is sane and silent the clang warning. Thanks. Looks good to me. [...] --- a/grep.c +++ b/grep.c @@ -625,7 +625,8 @@ static struct grep_expr