Re: [PATCH 1/3] git-multimail: Add an option to filter on branches

2015-04-22 Thread Dave Boutcher
On Wed, Apr 22, 2015 at 7:44 PM, Michael Haggerty mhag...@alum.mit.edu wrote: I think what you are looking for is return any(r.match(branch) for r in branches) Yup, thats exactly what I wanted. I'll submit an updated patch I was also wondering why you decided to support comma-separated

Re: [PATCH 1/3] git-multimail: Add an option to filter on branches

2015-04-22 Thread Michael Haggerty
On 04/22/2015 01:04 AM, Dave Boutcher wrote: Add a branches option to the config. Only changes pushed to specified branches will generate emails. Changes to tags will continue to generate emails. Thanks for the patches. Patches 2 and 3 seem uncontroversial, so I already merged them. Patch 1

Re: [PATCH 1/3] git-multimail: Add an option to filter on branches

2015-04-22 Thread Dave Boutcher
Thanks Michael, The only code I'm not fond of is matching on a list of regular expressions. There must be a more pythonic way to do: + return [x for x in [r.match(branch) for r in branches] if x] which basically returns true if branch matches any regular expression in the list. I pushed this

Re: [PATCH 1/3] git-multimail: Add an option to filter on branches

2015-04-22 Thread Michael Haggerty
On 04/22/2015 12:46 PM, Dave Boutcher wrote: The only code I'm not fond of is matching on a list of regular expressions. There must be a more pythonic way to do: + return [x for x in [r.match(branch) for r in branches] if x] which basically returns true if branch matches any regular

[PATCH 1/3] git-multimail: Add an option to filter on branches

2015-04-21 Thread Dave Boutcher
Add a branches option to the config. Only changes pushed to specified branches will generate emails. Changes to tags will continue to generate emails. Signed-off-by: Dave Boutcher daveboutc...@gmail.com --- git-multimail/README | 7 +++ git-multimail/git_multimail.py | 44