Re: [PATCH 1/3] git-verify-pack.txt: fix inconsistent spelling of packfile

2015-05-20 Thread Junio C Hamano
Jeff King p...@peff.net writes: On Tue, May 19, 2015 at 12:34:03PM -0700, Junio C Hamano wrote: A quick git grep packfile vs git grep pack-file inside Documentation/ directory indicates that we seem to use 'packfile' primarily in the lower-level technical documents that are not end-user

Re: [PATCH 1/3] git-verify-pack.txt: fix inconsistent spelling of packfile

2015-05-20 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: Jeff King p...@peff.net writes: On Tue, May 19, 2015 at 12:34:03PM -0700, Junio C Hamano wrote: A quick git grep packfile vs git grep pack-file inside Documentation/ directory indicates that we seem to use 'packfile' primarily in the lower-level

Re: [PATCH 1/3] git-verify-pack.txt: fix inconsistent spelling of packfile

2015-05-20 Thread Jeff King
On Wed, May 20, 2015 at 12:45:09PM -0700, Junio C Hamano wrote: One related thing is that there are few mentions of idx file to refer to pack index (e.g. show-index and verify-pack documentation pages); I think this was an attempt to disambiguate pack index from the Index, but as long as we

Re: [PATCH 1/3] git-verify-pack.txt: fix inconsistent spelling of packfile

2015-05-20 Thread Junio C Hamano
Jeff King p...@peff.net writes: On Wed, May 20, 2015 at 12:45:09PM -0700, Junio C Hamano wrote: One related thing is that there are few mentions of idx file to refer to pack index (e.g. show-index and verify-pack documentation pages); I think this was an attempt to disambiguate pack index

Re: [PATCH 1/3] git-verify-pack.txt: fix inconsistent spelling of packfile

2015-05-20 Thread Junio C Hamano
Jeff King p...@peff.net writes: Yeah, I agree they should agree with the EBNF. And my inclination is for packfile, as it is refering to the concept of the on-the-wire packfile data (there is no file ending in .pack in this context). Which I guess argues for a further patch. I'm fine with

Re: [PATCH 1/3] git-verify-pack.txt: fix inconsistent spelling of packfile

2015-05-20 Thread Jeff King
On Wed, May 20, 2015 at 03:37:23PM -0700, Junio C Hamano wrote: In any case, even though I merged these three to 'next', I think we need to either revert 3/3 or do s/pack-file/packfile/ throughout the pack-protocol documentation. The original has something like this: The pack-file MUST

[PATCH 1/3] git-verify-pack.txt: fix inconsistent spelling of packfile

2015-05-17 Thread Patrick Steinhardt
Signed-off-by: Patrick Steinhardt p...@pks.im --- Documentation/git-verify-pack.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/git-verify-pack.txt b/Documentation/git-verify-pack.txt index 526ba7b..61ca6d0 100644 --- a/Documentation/git-verify-pack.txt +++