Re: [PATCH 1/3] merge: allow reading the merge commit message from a file

2018-07-12 Thread Junio C Hamano
Johannes Schindelin writes: >> > +static int option_read_message(struct parse_opt_ctx_t *ctx, >> > + const struct option *opt, int unset) >> > +{ >> > + struct strbuf *buf = opt->value; >> > + const char *arg; >> > + >> > + if (unset) >> > + BUG("-F cannot be

Re: [PATCH 1/3] merge: allow reading the merge commit message from a file

2018-07-12 Thread Johannes Schindelin
Hi Junio, On Wed, 11 Jul 2018, Junio C Hamano wrote: > "Johannes Schindelin via GitGitGadget" > writes: > > > diff --git a/builtin/merge.c b/builtin/merge.c > > index 4a4c09496..b0e907751 100644 > > --- a/builtin/merge.c > > +++ b/builtin/merge.c > > @@ -111,6 +111,35 @@ static int

Re: [PATCH 1/3] merge: allow reading the merge commit message from a file

2018-07-11 Thread Junio C Hamano
"Johannes Schindelin via GitGitGadget" writes: > From: Johannes Schindelin > > This is consistent with `git commit` which, like `git merge`, supports > passing the commit message via `-m ` and, unlike `git merge` before > this patch, via `-F `. > > It is useful to allow this for scripted use,

[PATCH 1/3] merge: allow reading the merge commit message from a file

2018-07-11 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin This is consistent with `git commit` which, like `git merge`, supports passing the commit message via `-m ` and, unlike `git merge` before this patch, via `-F `. It is useful to allow this for scripted use, or for the upcoming patch to allow (re-)creating octopus