чт, 18 окт. 2018 г. в 9:51, Junio C Hamano :
>
> Jeff King writes:
>
> > Presumably it came from the manual comment-style fixup.
>
> Wow, that was embarrassing. Thanks for catching it.
Jeff, thanks a lot!
I just sent new version where I fixed all known issues including that comment.
>
> >
> >
Jeff King writes:
> Presumably it came from the manual comment-style fixup.
Wow, that was embarrassing. Thanks for catching it.
>
> With that fix, the tests run fine for me under ASan/UBSan (with the
> exception of t5310, but that's fixed already in a parallel topic).
>
> -Peff
On Fri, Oct 12, 2018 at 11:35:01AM +0900, Junio C Hamano wrote:
> Junio C Hamano writes:
>
> > Olga Telezhnaya writes:
>
> These three patches seem to cause t6300 to fail with an attempt to
> free an invalid pointer in "git for-each-ref --format='%(push)'"
> (6300.25)
I dug into this a bit.
Junio C Hamano writes:
> Olga Telezhnaya writes:
These three patches seem to cause t6300 to fail with an attempt to
free an invalid pointer in "git for-each-ref --format='%(push)'"
(6300.25)
*** Error in `/home/gitster/w/git.git/git': free(): invalid pointer:
0x55cca3a9f920 ***
===
Olga Telezhnaya writes:
> Release memory from used_atom variable.
That much readers would know from a quick look of the patch text.
Without knowing what you are aiming at, it is impossible to judge if
the patch is a good change.
Seeing FREE_AND_NULL(array->items) in the same function makes me
Release memory from used_atom variable.
Signed-off-by: Olga Telezhnaia
---
ref-filter.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/ref-filter.c b/ref-filter.c
index e1bcb4ca8a197..1b71d08a43a84 100644
--- a/ref-filter.c
+++ b/ref-filter.c
@@ -1996,6 +1996,9 @@ void
6 matches
Mail list logo
