Re: [PATCH 1/3] refs/packed-backend.c: close fd of empty file

2018-05-31 Thread Johannes Schindelin
Hi Stefan, I am Cc:ing Michael, the original author of the fixed commit. On Wed, 30 May 2018, Stefan Beller wrote: > Signed-off-by: Stefan Beller > --- > > This was an oversight in 01caf20d57a (load_contents(): don't try to mmap an > empty file, 2018-01-24). > > This and the following 2

Re: [PATCH 1/3] refs/packed-backend.c: close fd of empty file

2018-05-31 Thread Michael Haggerty
On Wed, May 30, 2018 at 7:03 PM, Stefan Beller wrote: > Signed-off-by: Stefan Beller > --- > > This was an oversight in 01caf20d57a (load_contents(): don't try to mmap an > empty file, 2018-01-24). > > This and the following 2 patches apply on master. > > refs/packed-backend.c | 1 + > 1 file

Re: [PATCH 1/3] refs/packed-backend.c: close fd of empty file

2018-05-30 Thread Jeff King
On Wed, May 30, 2018 at 10:03:00AM -0700, Stefan Beller wrote: > diff --git a/refs/packed-backend.c b/refs/packed-backend.c > index cec3fb9e00f..d447a731da0 100644 > --- a/refs/packed-backend.c > +++ b/refs/packed-backend.c > @@ -499,6 +499,7 @@ static int load_contents(struct snapshot *snapshot)

[PATCH 1/3] refs/packed-backend.c: close fd of empty file

2018-05-30 Thread Stefan Beller
Signed-off-by: Stefan Beller --- This was an oversight in 01caf20d57a (load_contents(): don't try to mmap an empty file, 2018-01-24). This and the following 2 patches apply on master. refs/packed-backend.c | 1 + 1 file changed, 1 insertion(+) diff --git a/refs/packed-backend.c