Re: [PATCH 1/3] stash: add test for stash create with no files

Joel Teichroeb writes: > On Sat, Aug 19, 2017 at 1:55 PM, Junio C Hamano wrote: >> >> Are you documenting an existing breakage? Are you extending test >> coverage for some breakage we recently fixed without adding tests to >> ensure that the fix will stay unbroken? Are you planning to touch >>

Re: [PATCH 1/3] stash: add test for stash create with no files

Hi Junio, I was just too lazy to write a cover letter, and thought these would make sense on their own. I'll make sure to include a cover letter next time. I just ripped them out of my patch series on implementing stash as a builtin[1]. Since I haven't had time, I figured I could at least get the

Re: [PATCH 1/3] stash: add test for stash create with no files

I see three patches that add tests, but it is hard to judge them without any explanation on what the point of them are. Are you documenting an existing breakage? Are you extending test coverage for some breakage we recently fixed without adding tests to ensure that the fix will stay unbroken? Ar

[PATCH 1/3] stash: add test for stash create with no files

Ensure the command suceeds and outputs nothing Signed-off-by: Joel Teichroeb --- t/t3903-stash.sh | 8 1 file changed, 8 insertions(+) diff --git a/t/t3903-stash.sh b/t/t3903-stash.sh index 4046817d70..f0708ced27 100755 --- a/t/t3903-stash.sh +++ b/t/t3903-stash.sh @@ -444,6 +444,14 @@