Re: [PATCH 1/3] stat_validity: handle non-regular files

On Sat, May 23, 2015 at 01:00:06PM +0200, Michael Haggerty wrote: I don't have any insight about whether mtimes are reliable change indicators for directories. But if you make this change, you are changing the contract of the stat_validity functions: * Have you verified that no callers

Re: [PATCH 1/3] stat_validity: handle non-regular files

On 05/23/2015 01:51 AM, Jeff King wrote: The stat_validity code was originally written to avoid re-reading the packed-refs file when it has not changed. It makes sure that the file continues to match S_ISREG() when we check it. However, we can use the same concept on a directory to see

[PATCH 1/3] stat_validity: handle non-regular files

The stat_validity code was originally written to avoid re-reading the packed-refs file when it has not changed. It makes sure that the file continues to match S_ISREG() when we check it. However, we can use the same concept on a directory to see whether it has been modified. Even though we still