On 2015-10-15 at 18:42:23 +0200, Matthieu Moy
wrote:
> Tobias Klauser writes:
>
> > Also switch all current users of stripspace() to the new function name
> > and keep a temporary wrapper inline function for topic branches still
> > using stripspace().
>
> Since you have this temporary wrappe
Thanks for the review.
On 2015-10-15 at 19:36:17 +0200, Junio C Hamano wrote:
> Tobias Klauser writes:
>
> > Rename stripspace() to strbuf_stripspace() and move it to the strbuf
> > module as suggested in [1].
> >
> > Also switch all current users of stripspace() to the new function name
> > an
Tobias Klauser writes:
> Rename stripspace() to strbuf_stripspace() and move it to the strbuf
> module as suggested in [1].
>
> Also switch all current users of stripspace() to the new function name
> and keep a temporary wrapper inline function for topic branches still
> using stripspace().
>
>
Tobias Klauser writes:
> [1]
> https://git.wiki.kernel.org/index.php/SmallProjectsIdeas#make_.27stripspace.28.29.27_part_of_strbuf
I don't think we want such references in the commit message. It does
make sense in a "below ---" comment, but commit messages are here to
stay forever, while the Sm
Tobias Klauser writes:
> Also switch all current users of stripspace() to the new function name
> and keep a temporary wrapper inline function for topic branches still
> using stripspace().
Since you have this temporary wrapper, it would have made sense to split
the patch into 1) move and renam
Rename stripspace() to strbuf_stripspace() and move it to the strbuf
module as suggested in [1].
Also switch all current users of stripspace() to the new function name
and keep a temporary wrapper inline function for topic branches still
using stripspace().
[1]
https://git.wiki.kernel.org/index
6 matches
Mail list logo
