[PATCH 1/3] t3404: preserve test_tick state across short SHA-1 collision test

The short SHA-1 collision test requires carefully crafted commits in order to ensure a collision at rebase time. This involves managing state which impacts the resulting SHA-1, including commit time. To accomplish this, test_tick is set to a known state for the short SHA-1 collision test. Unfortun

Re: [PATCH 1/3] t3404: preserve test_tick state across short SHA-1 collision test

Hi, Eric Sunshine wrote: > The short SHA-1 collision test requires carefully crafted commits in > order to ensure a collision at rebase time. Yeah, this breaks the usual rule that tests should be independent of hashing function. But it's the best we can do, I think. [...] > --- a/t/t3404-rebas

Re: [PATCH 1/3] t3404: preserve test_tick state across short SHA-1 collision test

On Sun, Aug 25, 2013 at 1:55 AM, Jonathan Nieder wrote: > Hi, > > Eric Sunshine wrote: > >> The short SHA-1 collision test requires carefully crafted commits in >> order to ensure a collision at rebase time. > > Yeah, this breaks the usual rule that tests should be independent > of hashing functio

Re: [PATCH 1/3] t3404: preserve test_tick state across short SHA-1 collision test

Eric Sunshine wrote: > On Sun, Aug 25, 2013 at 1:55 AM, Jonathan Nieder wrote: >> Would be clearer if the code in a subshell were indented: >> >> ( >> unset test_tick && >> test_commit ... >> ) > > I considered it, but decided against it for a coupl

Re: [PATCH 1/3] t3404: preserve test_tick state across short SHA-1 collision test

Jonathan Nieder writes: > Eric Sunshine wrote: >> On Sun, Aug 25, 2013 at 1:55 AM, Jonathan Nieder wrote: > >>> Would be clearer if the code in a subshell were indented: >>> >>> ( >>> unset test_tick && >>> test_commit ... >>> ) >> >> I considered