Re: [PATCH 1/3] t7504: document regression: reword no longer calls commit-msg

Hi Sebastian, On Thu, 23 Mar 2017, Sebastian Schuberth wrote: > On Thu, Mar 23, 2017 at 3:43 PM, Johannes Schindelin > wrote: > > > I know Sebastian well, and I would hope that he lends his substantial > > competence to making sure that the changes that affect end

Re: [PATCH 1/3] t7504: document regression: reword no longer calls commit-msg

On Thu, Mar 23, 2017 at 3:43 PM, Johannes Schindelin wrote: > I know Sebastian well, and I would hope that he lends his substantial > competence to making sure that the changes that affect end users are > correct and that I do not introduce another regression. If

Re: [PATCH 1/3] t7504: document regression: reword no longer calls commit-msg

Hi Junio, On Wed, 22 Mar 2017, Junio C Hamano wrote: > Johannes Schindelin writes: > > > In any case, this is *test* code. So I'd prefer to have the changes to > > the C code scrutinized a bit more, not the test code as long as it is > > obvious what it does. > >

Re: [PATCH 1/3] t7504: document regression: reword no longer calls commit-msg

Hi Junio, On Wed, 22 Mar 2017, Junio C Hamano wrote: > Sebastian Schuberth writes: > > > On Wed, Mar 22, 2017 at 4:01 PM, Johannes Schindelin > > wrote: > > > >> Noticed by Sebastian Schuberth. > > > > Thanks for working on the fix. > > > >>

Re: [PATCH 1/3] t7504: document regression: reword no longer calls commit-msg

Johannes Schindelin writes: > In any case, this is *test* code. So I'd prefer to have the changes to the > C code scrutinized a bit more, not the test code as long as it is obvious > what it does. I do not think the tone of this comment serves any productive purpose.

Re: [PATCH 1/3] t7504: document regression: reword no longer calls commit-msg

Sebastian Schuberth writes: > On Wed, Mar 22, 2017 at 4:01 PM, Johannes Schindelin > wrote: > >> Noticed by Sebastian Schuberth. > > Thanks for working on the fix. > >> +# set up fake editor to replace `pick` by `reword` >> +cat > reword-editor

Re: [PATCH 1/3] t7504: document regression: reword no longer calls commit-msg

Hi Sebastian, On Wed, 22 Mar 2017, Sebastian Schuberth wrote: > On Wed, Mar 22, 2017 at 4:01 PM, Johannes Schindelin > wrote: > > > +# set up fake editor to replace `pick` by `reword` > > +cat > reword-editor <<'EOF' > > +#!/bin/sh > > +mv "$1" "$1".bup && > > +sed

Re: [PATCH 1/3] t7504: document regression: reword no longer calls commit-msg

On Wed, Mar 22, 2017 at 4:01 PM, Johannes Schindelin wrote: > Noticed by Sebastian Schuberth. Thanks for working on the fix. > +# set up fake editor to replace `pick` by `reword` > +cat > reword-editor <<'EOF' > +#!/bin/sh > +mv "$1" "$1".bup && > +sed

[PATCH 1/3] t7504: document regression: reword no longer calls commit-msg

The `reword` command of an interactive rebase used to call the commit-msg hooks, but that regressed when we switched to the rebase--helper backed by the sequencer. Noticed by Sebastian Schuberth. Signed-off-by: Johannes Schindelin --- t/t7504-commit-msg-hook.sh | 17