Re: [PATCH 1/3] tree.c: update read_tree_recursive callback to pass strbuf as base

2014-12-08 Thread Duy Nguyen
On Wed, Dec 3, 2014 at 11:13 PM, Junio C Hamano wrote: > A question during the review, especially on proposed log messages > and documentation changes, is rarely just a request to explain it to > the questioner in the discussion. It is an indication that what is > being commented on needs tweaking

Re: [PATCH 1/3] tree.c: update read_tree_recursive callback to pass strbuf as base

2014-12-03 Thread Junio C Hamano
Eric Sunshine writes: > On Tue, Dec 2, 2014 at 7:11 AM, Duy Nguyen wrote: >> On Tue, Dec 2, 2014 at 2:32 AM, Junio C Hamano wrote: >>> Nguyễn Thái Ngọc Duy writes: >>> This allows the callback to use 'base' as a temporary buffer to quickly assemble full path "without" extra allocati

Re: [PATCH 1/3] tree.c: update read_tree_recursive callback to pass strbuf as base

2014-12-02 Thread Eric Sunshine
On Tue, Dec 2, 2014 at 7:11 AM, Duy Nguyen wrote: > On Tue, Dec 2, 2014 at 2:32 AM, Junio C Hamano wrote: >> Nguyễn Thái Ngọc Duy writes: >> >>> This allows the callback to use 'base' as a temporary buffer to >>> quickly assemble full path "without" extra allocation. The callback >>> has to res

Re: [PATCH 1/3] tree.c: update read_tree_recursive callback to pass strbuf as base

2014-12-02 Thread Duy Nguyen
On Tue, Dec 2, 2014 at 2:32 AM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> This allows the callback to use 'base' as a temporary buffer to >> quickly assemble full path "without" extra allocation. The callback >> has to restore it afterwards of course. > > Hmph, what's the quote a

Re: [PATCH 1/3] tree.c: update read_tree_recursive callback to pass strbuf as base

2014-12-01 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > This allows the callback to use 'base' as a temporary buffer to > quickly assemble full path "without" extra allocation. The callback > has to restore it afterwards of course. Hmph, what's the quote around 'without' doing there? -- To unsubscribe from this list:

[PATCH 1/3] tree.c: update read_tree_recursive callback to pass strbuf as base

2014-11-30 Thread Nguyễn Thái Ngọc Duy
This allows the callback to use 'base' as a temporary buffer to quickly assemble full path "without" extra allocation. The callback has to restore it afterwards of course. Helped-by: Eric Sunshine Signed-off-by: Nguyễn Thái Ngọc Duy --- archive.c | 34 +-

Re: [PATCH 1/3] tree.c: update read_tree_recursive callback to pass strbuf as base

2014-11-08 Thread Eric Sunshine
On Sat, Nov 8, 2014 at 6:00 AM, Nguyễn Thái Ngọc Duy wrote: > This allows the callback to use 'base' as a temporary buffer to > quickly assemble full path "without" extra allocation. The caller has > to restore it afterwards of course. > > Signed-off-by: Nguyễn Thái Ngọc Duy > --- > diff --git a/

Re: [PATCH 1/3] tree.c: update read_tree_recursive callback to pass strbuf as base

2014-11-08 Thread Duy Nguyen
On Sat, Nov 8, 2014 at 6:00 PM, Nguyễn Thái Ngọc Duy wrote: > This allows the callback to use 'base' as a temporary buffer to > quickly assemble full path "without" extra allocation. The caller has Errr.. the _callback_ has to. restore... > to restore it afterwards of course. -- Duy -- To unsub

[PATCH 1/3] tree.c: update read_tree_recursive callback to pass strbuf as base

2014-11-08 Thread Nguyễn Thái Ngọc Duy
This allows the callback to use 'base' as a temporary buffer to quickly assemble full path "without" extra allocation. The caller has to restore it afterwards of course. Signed-off-by: Nguyễn Thái Ngọc Duy --- archive.c | 10 +- builtin/checkout.c | 8 builtin/log.c