Re: [PATCH 1/3] upload-pack: Remove a piece of dead code

2013-07-11 Thread Junio C Hamano
Duy Nguyen writes: > On Thu, Jul 11, 2013 at 6:25 PM, Matthijs Kooijman wrote: >> Commit 682c7d2 (upload-pack: fix off-by-one depth calculation in shallow >> clone) introduced a new check in get_shallow_commits to decide when to >> stop traversing the history and mark the current commit as a sha

Re: [PATCH 1/3] upload-pack: Remove a piece of dead code

2013-07-11 Thread Duy Nguyen
On Thu, Jul 11, 2013 at 6:25 PM, Matthijs Kooijman wrote: > Commit 682c7d2 (upload-pack: fix off-by-one depth calculation in shallow > clone) introduced a new check in get_shallow_commits to decide when to > stop traversing the history and mark the current commit as a shallow > root. > > With this

[PATCH 1/3] upload-pack: Remove a piece of dead code

2013-07-11 Thread Matthijs Kooijman
Commit 682c7d2 (upload-pack: fix off-by-one depth calculation in shallow clone) introduced a new check in get_shallow_commits to decide when to stop traversing the history and mark the current commit as a shallow root. With this new check in place, the old check can no longer be true, since the fi