Re: [PATCH 1/4] Doc/config.txt: explain repeated sections

2017-07-10 Thread Junio C Hamano
Jeff King writes: > FWIW, the use of "multivalued" here tickled my spider sense, too. I > think when talking on the list we generally reserve "multivalued" for > true "we expect this to be a list" variables. But the only mention of > "multivalued" in the config documentation seems

Re: [PATCH 1/4] Doc/config.txt: explain repeated sections

2017-07-10 Thread Jeff King
On Sun, Jul 09, 2017 at 12:57:07AM -0700, Junio C Hamano wrote: > Junio C Hamano writes: > > >> +Multiple occurrences of the same section are all logically merged. > >> (There's > >> +no special treatment for variables defined multiple times across > >> physically > >>

Re: [PATCH 1/4] Doc/config.txt: explain repeated sections

2017-07-09 Thread Junio C Hamano
Junio C Hamano writes: >> +Multiple occurrences of the same section are all logically merged. (There's >> +no special treatment for variables defined multiple times across physically >> +different sections, the variable is simply made multivalued.) >> + > > Looks correct;

Re: [PATCH 1/4] Doc/config.txt: explain repeated sections

2017-07-08 Thread Junio C Hamano
astian writes: > Add a paragraph explaining what happens when a section name is repeated > in the configuration file(s). > > The example configuration file shown in this document already implied > Git's behaviour, this patch simply tries to make it explicit. > > Signed-off-by:

[PATCH 1/4] Doc/config.txt: explain repeated sections

2017-07-08 Thread astian
Add a paragraph explaining what happens when a section name is repeated in the configuration file(s). The example configuration file shown in this document already implied Git's behaviour, this patch simply tries to make it explicit. Signed-off-by: astian ---