Re: [PATCH 1/4] git-prompt.sh: add submodule indicator

2017-02-06 Thread Stefan Beller
On Sun, Feb 5, 2017 at 9:55 PM, Jacob Keller wrote: > On Sun, Feb 5, 2017 at 8:23 PM, Stefan Beller wrote: >> >> (unrelated side note:) >> At GitMerge facebook presented their improvements on mercurial >> and one of the things was "hg absorb". It would take the dirty hunks/lines >> of the working

Re: [PATCH 1/4] git-prompt.sh: add submodule indicator

2017-02-05 Thread Jacob Keller
On Sun, Feb 5, 2017 at 8:23 PM, Stefan Beller wrote: > > (unrelated side note:) > At GitMerge facebook presented their improvements on mercurial > and one of the things was "hg absorb". It would take the dirty hunks/lines > of the working tree and amend them into the "stack of commits", i.e. into

Re: [PATCH 1/4] git-prompt.sh: add submodule indicator

2017-02-05 Thread Stefan Beller
On Mon, Jan 30, 2017 at 7:11 PM, Junio C Hamano wrote: > Benjamin Fuchs writes: > >> In [2/4] I got rid of the loop by feedback of Gábor. >> Sorry if my patch wasn't well formed. > > While it might be the way other development communities work, in the > Git development community, we do not work t

Re: [PATCH 1/4] git-prompt.sh: add submodule indicator

2017-01-30 Thread Junio C Hamano
Benjamin Fuchs writes: > In [2/4] I got rid of the loop by feedback of Gábor. > Sorry if my patch wasn't well formed. While it might be the way other development communities work, in the Git development community, we do not work that way when presenting your second and subsequent attempt to the

Re: [PATCH 1/4] git-prompt.sh: add submodule indicator

2017-01-30 Thread Benjamin Fuchs
Hi Junio, thanks for your reply. Some of your suggestions are covered by my rework in Patch [2/4]. In [2/4] I got rid of the loop by feedback of Gábor. Sorry if my patch wasn't well formed. On 31.01.2017 00:48, Junio C Hamano wrote: Benjamin Fuchs writes: I expirienced that working with sub

Re: [PATCH 1/4] git-prompt.sh: add submodule indicator

2017-01-30 Thread Junio C Hamano
Benjamin Fuchs writes: > I expirienced that working with submodules can be confusing. This indicator > will make you notice very easy when you switch into a submodule. I am not quite sure what the above wants to say. If you work on two projects, A and B, then having something that quickly remin

[PATCH 1/4] git-prompt.sh: add submodule indicator

2017-01-30 Thread Benjamin Fuchs
I expirienced that working with submodules can be confusing. This indicator will make you notice very easy when you switch into a submodule. The new prompt will look like this: (sub:master) Adding a new optional env variable for the new feature. Signed-off-by: Benjamin Fuchs --- contrib/completi