Re: [PATCH 1/5] Add a new option 'merges' to revision.c

2015-03-22 Thread Eric Sunshine
On Sun, Mar 22, 2015 at 2:28 PM, Koosha Khajehmoogahi koo...@posteo.de wrote: Subject: Add a new option 'merges' to revision.c For the subject, mention the area you're touching, followed by a colon, followed by a short but meaningful summary of the change. Drop capitalization. revision: add

[PATCH 1/5] Add a new option 'merges' to revision.c

2015-03-22 Thread Koosha Khajehmoogahi
revision.c: add a new option 'merges' with possible values of 'only', 'show' and 'hide'. The option is used when showing the list of commits. The value 'only' lists only merges. The value 'show' is the default behavior which shows the commits as well as merges and the value 'hide' makes it just

Re: [PATCH 1/5] Add a new option 'merges' to revision.c

2015-03-22 Thread Junio C Hamano
Koosha Khajehmoogahi koo...@posteo.de writes: @@ -1800,9 +1817,14 @@ static int handle_revision_opt(struct rev_info *revs, int argc, const char **arg revs-show_all = 1; } else if (!strcmp(arg, --remove-empty)) { revs-remove_empty_trees = 1; + } else if

Re: [PATCH 1/5] Add a new option 'merges' to revision.c

2015-03-22 Thread Junio C Hamano
Koosha Khajehmoogahi koo...@posteo.de writes: } else if (!strcmp(arg, --merges)) { + revs-max_parents = -1; revs-min_parents = 2; But is this change warranted? An existing user who is not at all interested in the new --merges= option may be relying on the fact

Re: [PATCH 1/5] Add a new option 'merges' to revision.c

2015-03-22 Thread Koosha Khajehmoogahi
On 03/23/2015 12:31 AM, Junio C Hamano wrote: Koosha Khajehmoogahi koo...@posteo.de writes: @@ -1800,9 +1817,14 @@ static int handle_revision_opt(struct rev_info *revs, int argc, const char **arg revs-show_all = 1; } else if (!strcmp(arg, --remove-empty)) {