Re: [PATCH 1/5] progress.c: replace signal() with sigaction()

2014-05-28 Thread Junio C Hamano
David Kastrup writes: >>> diff --git a/progress.c b/progress.c >>> index 261314e..24df263 100644 >>> --- a/progress.c >>> +++ b/progress.c >>> @@ -66,8 +66,12 @@ static void set_progress_signal(void) >>> static void clear_progress_signal(void) >>> { >>> struct itimerval v = {{0,},}; >>> +

Re: [PATCH 1/5] progress.c: replace signal() with sigaction()

2014-05-28 Thread Jeremiah Mahler
On Wed, May 28, 2014 at 08:07:38PM +1200, Chris Packham wrote: > On 28/05/14 18:14, Jeremiah Mahler wrote: > > From signal(2) > > > > The behavior of signal() varies across UNIX versions, and has also var‐ > > ied historically across different versions of Linux. Avoid its use: > > use si

Re: [PATCH 1/5] progress.c: replace signal() with sigaction()

2014-05-28 Thread David Kastrup
Erik Faye-Lund writes: > On Wed, May 28, 2014 at 10:19 AM, David Kastrup wrote: >> Chris Packham writes: >> >>> On 28/05/14 18:14, Jeremiah Mahler wrote: static void clear_progress_signal(void) { struct itimerval v = {{0,},}; +struct sigaction sa; + +

Re: [PATCH 1/5] progress.c: replace signal() with sigaction()

2014-05-28 Thread Erik Faye-Lund
On Wed, May 28, 2014 at 10:19 AM, David Kastrup wrote: > Chris Packham writes: > >> On 28/05/14 18:14, Jeremiah Mahler wrote: >>> From signal(2) >>> >>> The behavior of signal() varies across UNIX versions, and has also var‐ >>> ied historically across different versions of Linux. Avoid it

Re: [PATCH 1/5] progress.c: replace signal() with sigaction()

2014-05-28 Thread David Kastrup
Chris Packham writes: > On 28/05/14 18:14, Jeremiah Mahler wrote: >> From signal(2) >> >> The behavior of signal() varies across UNIX versions, and has also var‐ >> ied historically across different versions of Linux. Avoid its use: >> use sigaction(2) instead. See Portability below.

Re: [PATCH 1/5] progress.c: replace signal() with sigaction()

2014-05-28 Thread Chris Packham
On 28/05/14 18:14, Jeremiah Mahler wrote: > From signal(2) > > The behavior of signal() varies across UNIX versions, and has also var‐ > ied historically across different versions of Linux. Avoid its use: > use sigaction(2) instead. See Portability below. Minor nit. The last sentence a

[PATCH 1/5] progress.c: replace signal() with sigaction()

2014-05-27 Thread Jeremiah Mahler
>From signal(2) The behavior of signal() varies across UNIX versions, and has also var‐ ied historically across different versions of Linux. Avoid its use: use sigaction(2) instead. See Portability below. Replaced signal() with sigaction() in progress.c Signed-off-by: Jeremiah Mahler