[PATCH 1/5] remote: don't use remote->{fetch,push}_refspec

2017-06-16 Thread SZEDER Gábor
builtin/remote.c uses remote->fetch_refspec and remote->push_refspec, i.e. refspecs as strings, in a few places, e.g. in an error message or to set configuration variables. Since we are about to eliminate remote->{fetch,push}_refspec, recreate those strings from the corresponding remote->{fetch,pu

Re: [PATCH 1/5] remote: don't use remote->{fetch,push}_refspec

2017-06-16 Thread Junio C Hamano
SZEDER Gábor writes: > diff --git a/remote.c b/remote.c > index 336db8298..a021decee 100644 > --- a/remote.c > +++ b/remote.c > @@ -919,6 +919,26 @@ char *apply_refspecs(struct refspec *refspecs, int > nr_refspec, > return query.dst; > } > > +void strbuf_add_refspec(struct strbuf *sb, c